-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wl shell protocol implementation #456
Conversation
I'm not terribly interested in wl_shell support. But I guess someone needs it. Although I'd ask if sailfish os already has xdg shell. If it does then I don't see much purpose beyond legacy support (which you did mention). For winit you'll need to convince @kchibisov, just making a pull request here doesn't guarantee winit will use the wl_shell code here. |
As I know there is no xdg support in Sailfosh OS. The next step is to contribute in winit, if this PR will be merged. Or you mean winit's maintainers may not approve implementation for deprecated protocol? |
We explicitly dropped |
I see. But compositor in Sailfish OS still uses If it's a big problem to have this code in repository, I'll fork it. But I think it's not a big deal to implement it as feature, that will uses only if needs, and xdg will use by default. |
I'm not interested in maintaining protocols no one can really test in winit. I'd suggest to update sailfish instead. |
And why do you think nobody can test these protocols? I agree with your suggestion, but I only do what I can do, and So, you won't accept PR for these protocols for |
I won't accept them for winit, since all mainline compositors don't support them anymore, meaning that average contributor can not test them, because they require special setups, etc. |
Make available using wl shell protocol for windows creation.
Important
This implementation is only for make available to create windows in Sailfish OS by
winit
.I don't know what else it is need for, because it's deprecated and xdg uses everywhere.