Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October 2024 release #156

Merged
merged 19 commits into from
Oct 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9b462a3
BUG: fix UI sometimes had undefined state by using checkboxes instead…
mauigna06 Sep 20, 2024
4e69525
ENH: icon for "update fibula planes" button
mauigna06 Sep 21, 2024
1bf3f01
BUG: fix setOriginalMandibleVisility function
mauigna06 Sep 21, 2024
c019a6f
ENH: allow locking of current VSP
mauigna06 Sep 23, 2024
e10f5d3
ENH: add icons to control visibility of planning objects
mauigna06 Sep 28, 2024
0de075b
ENH: add indicatorIcon for cktCheckbox
mauigna06 Sep 28, 2024
2aa807e
ENH: add optional inter-condylar beam to neomandible mandible model
mauigna06 Sep 28, 2024
4d7d10c
DOC: explain use of inter-condylar beam feature
mauigna06 Sep 28, 2024
63c6511
ENH: allow report bugs and request features with ease
mauigna06 Sep 28, 2024
751fcd4
ENH: add open documentation button to GUI
mauigna06 Sep 28, 2024
2a7aa5a
ENH: create issue templates
mauigna06 Sep 29, 2024
9fe2487
ENH: add BRP version indicator label on module widget GUI
mauigna06 Sep 29, 2024
fd22196
BUG: inter-condylar beam selector was not disabled on when locking wa…
mauigna06 Sep 30, 2024
d57f0b6
DOC: clarify how to save a plan and how to export 3D models
mauigna06 Sep 30, 2024
4fc558f
ENH: improve fibula pieces security margin logic and GUI
mauigna06 Sep 30, 2024
4ad6995
DOC: add report issue link
mauigna06 Sep 30, 2024
7d60e61
DOC: correct table of contents, explain how to use the new lighting f…
mauigna06 Sep 30, 2024
42bee95
ENH: add more icons to the GUI
mauigna06 Oct 1, 2024
3c519ef
BUG: correct visibility behavior of mandible planes and their interac…
mauigna06 Oct 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
name: Bug report
about: Report problems or unexpected behavior
title: ''
labels: type:bug
assignees: ''

---

## Summary

<!-- Give a short summary of what the problem is. Note: If you are not sure if BoneReconstructionPlanner works incorrectly or you are not using it as intended then clarify it by asking on the Slicer Forum - https://discourse.slicer.org -->

## Steps to reproduce

<!--
Generally, BoneReconstructionPlanner developers can only fix those issues that they can reproduce on their computers.

To achieve this, please:
* Describe in this section what you did, what you expected to happen, and what happened instead.
* Attach a few screenshots if possible.
* Use one of the BoneReconstructionPlanner sample data sets (in Sample Data module) as inputs. If you cannot reproduce the problem with sample data sets then you can upload your data somewhere and provide a download link here (make sure to remove all patient information from the data before sharing).

If the problem cannot be reproduced by using the graphical user interface but only by running custom Python or C++ code then please create a short self-contained example as described at http://sscce.org

To describe "Actual behavior" and "Expected behavior" you may use the following format:
1. Do A
2. Do B => BoneReconstructionPlanner does Y - OK
3. Do C => BoneReconstructionPlanner does Z => ERROR: BoneReconstructionPlanner should do W instead
4. Do D => BoneReconstructionPlanner does Z - OK
5. Do B => BoneReconstructionPlanner does Y => ERROR: BoneReconstructionPlanner should do X instead
-->

## Environment
- BoneReconstructionPlanner version: Slicer-5.??.?-YYYY-MM-DD
- Operating system: Windows / Linux / Mac + which version
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Feature request
about: Suggest a new feature or enhancement for this project
title: ''
labels: type:enhancement
assignees: ''

---

## Is your feature request related to a problem? Please describe.

<!-- Description of what the problem is. For example, "I'm always frustrated when..." -->

## Describe the solution you'd like

<!-- Description of what you want to happen. -->

## Describe alternatives you've considered

<!-- Description of any alternative solutions or features you've considered. -->

## Additional context

<!-- Add any other context or screenshots about the feature request here. -->
32 changes: 32 additions & 0 deletions BoneReconstructionPlanner/BRPLib/guiWidgets.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
from __main__ import ctk, qt

class checkablePushButtonWithIcon(ctk.ctkCheckablePushButton):
def __init__(self, text="", icon=qt.QIcon(), parent=None):
super().__init__(parent)
self.text = text
#
self._mainLayout = qt.QHBoxLayout(self)
self._mainLayout.setContentsMargins(0, 0, 0, 0)
#self._mainLayout.setSpacing(15)
#self._mainLayout.setSpacing(300)
#
self.icon = icon
self._iconSize = qt.QSize(36, 36)
pixmap = self.icon.pixmap(self._iconSize)
self._iconLabel = qt.QLabel()
self._iconLabel.setAlignment(qt.Qt.AlignCenter)
self._iconLabel.setPixmap(pixmap)
self._iconLabel.setFixedSize(self._iconSize)
self._mainLayout.addSpacing(self.sizeHint.width())
self._mainLayout.addWidget(self._iconLabel)
self.setMinimumWidth(self.sizeHint.width() + self._iconSize.width())
self.setSizePolicy(qt.QSizePolicy.Maximum, qt.QSizePolicy.Fixed)

# use it with ctk.ctkCheckBox.indicatorIcon = iconWithGreyOut(iconPath)
def iconWithGreyOut(iconPath, size = qt.QSize(24, 24)):
iconPixmap = qt.QPixmap(iconPath)
iconWithGreyOut = qt.QIcon()
iconWithGreyOut.addPixmap(iconPixmap, qt.QIcon.Normal, qt.QIcon.On)
grayed = iconWithGreyOut.pixmap(size, qt.QIcon.Disabled, qt.QIcon.On)
iconWithGreyOut.addPixmap(grayed, qt.QIcon.Normal, qt.QIcon.Off)
return iconWithGreyOut
344 changes: 281 additions & 63 deletions BoneReconstructionPlanner/BoneReconstructionPlanner.py

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions BoneReconstructionPlanner/Resources/Icons/axes.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions BoneReconstructionPlanner/Resources/Icons/bone_48.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions BoneReconstructionPlanner/Resources/Icons/lock_48.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions BoneReconstructionPlanner/Resources/Icons/mail_48.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions BoneReconstructionPlanner/Resources/Icons/target_48.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions BoneReconstructionPlanner/Resources/Icons/update_48.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading