Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt with new dependencies, add api and test. #83

Closed
wants to merge 2 commits into from

Conversation

ZYLIII
Copy link
Contributor

@ZYLIII ZYLIII commented Sep 4, 2024

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZYLIII, thanks for your contribution. Please check the comment I leaved.

And I believe you may want to add api_test.png to the README.md

And also, check https://github.com/SkywardAI/voyager/pull/83/checks?check_run_id=29651859240 to do the sign off

uvicorn==0.29.0
httpx==0.27.0
streamlit==1.37.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only add streamlit==1.37.1. We don't need the others.

@Aisuko Aisuko self-assigned this Sep 4, 2024
@Aisuko Aisuko added enhancement New feature or request python labels Sep 4, 2024
@cbh778899
Copy link
Collaborator

Is this PR conflict with #84? Should we close it?

@Aisuko Aisuko closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants