-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llamaindex support #1758
Merged
Merged
llamaindex support #1758
+646
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to d0df598 in 2 minutes and 31 seconds
More details
- Looked at
185
lines of code in6
files - Skipped
1
files when reviewing. - Skipped posting
10
drafted comments based on config settings.
1. pyproject.toml:57
- Draft comment:
Dependency addition: Verify that the version '^0.12.16' of llama-index is compatible with the rest of the project and will not introduce conflicts. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to verify compatibility of a dependency version, which is against the rules. It does not provide a specific suggestion or point out a specific issue with the code.
2. skyvern/agent/parameter.py:7
- Draft comment:
Ensure consistency in attribute naming; TaskV1Request uses 'max_steps' while TaskV2Request uses 'max_iterations'. Confirm both are intentional. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. skyvern/langchain/remote.py:12
- Draft comment:
Using TaskV1Request.model_validate(task) is appropriate for pydantic v2. Confirm that all incoming data adheres to the expected structure. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is informative and asks the author to confirm that all incoming data adheres to the expected structure, which violates the rule against asking for confirmation of intention or behavior. It does not provide a specific code suggestion or ask for a specific test to be written.
4. skyvern/llama_index/local.py:7
- Draft comment:
Consider replacing the async lambda with a named async function for better debuggability and clearer error handling. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
While named functions can improve stack traces and debugging, these lambdas are extremely simple pass-through functions. They don't contain any real logic or error handling that would benefit from being broken out. The lambdas make the tool definitions more concise and keep related code together. The suggestion feels like over-engineering for this case.
Named functions could make stack traces clearer if errors occur. The code might grow more complex in the future where having separate functions would be beneficial.
The current lambdas are so simple that stack traces would still be clear - errors would likely come from the Agent class methods. Future complexity should be handled when/if it actually occurs.
Delete this comment as it suggests a refactor that would add complexity without providing meaningful benefits given the current simple pass-through nature of the lambdas.
5. skyvern/llama_index/remote.py:7
- Draft comment:
As with the local version, using async lambdas can obscure stack traces. Consider using named functions to improve maintainability. - Reason this comment was not posted:
Marked as duplicate.
6. pyproject.toml:55
- Draft comment:
Added dependency for llama-index looks good. Ensure its version (^0.12.16) is fully compatible with the imported modules (e.g. FunctionTool from llama_index.core.tools). - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
7. skyvern/agent/parameter.py:7
- Draft comment:
Consider standardizing field names between TaskV1Request (max_steps) and TaskV2Request (max_iterations) if they denote similar limits. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
8. skyvern/langchain/remote.py:16
- Draft comment:
Consider adding error handling around TaskV1Request.model_validate(task) (and similarly for TaskV2) to give clearer feedback on input validation failures. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
9. skyvern/llama_index/local.py:7
- Draft comment:
Agent() is instantiated within the lambda for each call. If Agent holds state or is expensive to create, consider reusing an instance. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
10. skyvern/llama_index/remote.py:7
- Draft comment:
Default endpoint value 'https://api.skyvern.com' is repeated in lambdas. Consider centralizing it to avoid duplication and potential mismatches. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_7jzRmxThgMwDSFQv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
wintonzheng
approved these changes
Feb 11, 2025
d0df598
to
522c5d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add llama-index support with new local and remote task execution capabilities and refactor task schemas.
llama-index
version^0.12.16
topyproject.toml
.local.py
inskyvern/llama_index
to support local task execution usingFunctionTool
forTaskV1Request
andTaskV2Request
.remote.py
inskyvern/llama_index
to support remote task execution usingFunctionTool
forRunTaskV1Schema
,RunTaskV2Schema
, andGetTaskSchema
.RunTaskV1Schema
,RunTaskV2Schema
, andGetTaskSchema
fromskyvern/langchain/remote.py
toskyvern/agent/parameter.py
.skyvern/langchain/remote.py
to use the new schemas for task execution.This description was created by
for d0df598. It will automatically update as commits are pushed.