fix max_iterations_override

[wintonzheng]

Important

Update x_max_iterations_override type in observer_task to accept int, str, or None.

• Behavior:
  • Update x_max_iterations_override type in observer_task to accept int, str, or None.
• Logging:
  • Logs max iterations override value in observer_task if provided.

^{This description was created by for 2c7155d. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 2c7155d in 51 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/routes/agent_protocol.py:1196

• Draft comment:
  Accepting both int and str is fine if intentional, but consider converting a str to int before use. Without conversion, a string header might lead to unexpected behavior when used as numeric override.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_6K1cyeL5XKm36xMz

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Allowing x_max_iterations_override to be int | str may lead to inconsistent behavior. If an integer override is expected, consider converting the header value to int explicitly and using an explicit None check (e.g. 'if x_max_iterations_override is not None') to avoid misinterpreting 0. Also, align its type with similar parameters (like x_max_steps_override).

[ellipsis-dev]

👍 Looks good to me! Incremental review on 2c7155d in 56 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern/forge/sdk/routes/agent_protocol.py:1196

• Draft comment:
  Consider converting string header input to int. Allowing int|str is fine for flexibility, but later usage may expect numeric value. If a string is received, explicitly cast it to int or validate it to avoid unexpected behavior.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
  The comment raises a valid concern about type safety. However, I don't see strong evidence that this will cause issues - the value is only used for logging and passed through to another function. Without seeing how execute_cruise() uses this value, I can't be certain that string values would cause problems. The type change to allow strings may have been intentional.
  I don't have visibility into how execute_cruise() uses this value. The type change to allow strings may have been done deliberately to support string inputs.
  While type safety is good, without seeing the full context of how this value is used, I can't be confident that requiring int conversion is the right approach.
  Delete the comment since we don't have strong evidence that string values would cause problems, and the type change may have been intentional.

2. skyvern/forge/sdk/routes/agent_protocol.py:1196

• Draft comment:
  Allowing x_max_iterations_override to be a string is useful since HTTP headers are strings, but ensure that if an integer is required downstream, you validate and convert this value appropriately.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_DlJJ7dmWjUYqlWN9

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.