Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round the top edges of template cards #1721

Merged

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Feb 4, 2025

Important

Rounds top edges of template cards in WorkflowTemplateCard.tsx by adding rounded-t-xl.

  • UI Enhancement:
    • Rounds the top edges of the template cards in WorkflowTemplateCard.tsx by adding rounded-t-xl to the outer div containing the image.

This description was created by Ellipsis for 0696a30. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Rounds top edges of template cards in `WorkflowTemplateCard.tsx`.
>
>   - **UI Enhancement**:
>     - Rounds the top edges of template cards in `WorkflowTemplateCard.tsx` by adding `rounded-t-xl` to the outer `div` containing the image.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for fb9cb977c9b7e2d9fcfc1d0a61217809535d153b. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 0696a30 in 53 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern-frontend/src/routes/discover/WorkflowTemplateCard.tsx:10
  • Draft comment:
    Consider adding 'overflow-hidden' to the container so the image respects the rounded corners.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    According to the rules, we should NOT comment on pure frontend UI or styling changes - we should assume the author made UI changes correctly. While the suggestion about overflow-hidden might be technically correct, it falls into the category of UI styling that we're supposed to trust the author with.
    The comment could be pointing out a functional issue where images might visibly overflow their container, which could be considered a bug rather than just styling.
    Even if it's a potential visual bug, it's still primarily a UI styling concern. The rules explicitly state to trust the author on UI changes.
    Delete the comment as it relates purely to UI styling, which according to the rules we should assume the author has handled correctly.
2. skyvern-frontend/src/routes/discover/WorkflowTemplateCard.tsx:10
  • Draft comment:
    Consider adding 'overflow-hidden' to the container div so that the image respects the rounded top edges.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_YTExlZfhguJeEwVY


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0696a30 in 53 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern-frontend/src/routes/discover/WorkflowTemplateCard.tsx:10
  • Draft comment:
    Correctly moved the rounded-t-xl class to the parent container to ensure proper clipping of the image.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    None
2. skyvern-frontend/src/routes/discover/WorkflowTemplateCard.tsx:10
  • Draft comment:
    Consider adding 'overflow-hidden' to the container. Without it, moving the 'rounded-t-xl' from the image to the div may not clip the image's corners.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    While the comment is technically correct about how rounded corners and overflow work in CSS, it violates our rules. This is a pure frontend UI/styling change, and per the rules we should "NOT comment on any pure frontend UI or styling changes, only logic. Assume that if the author changed the UI, they did it correctly."
    The comment is technically accurate about CSS behavior. Maybe UI issues are important enough to warrant breaking the rules?
    No - the rules are clear that we should trust the author on UI changes. If there are visual issues, they will be obvious in testing.
    Delete this comment as it relates purely to UI styling, which we are instructed to assume the author has handled correctly.

Workflow ID: wflow_aixIcCXikFhfJMaS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 27b2551 into main Feb 4, 2025
7 checks passed
@msalihaltun msalihaltun deleted the salih/template-card-top-corners-should-be-rounded branch February 4, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants