do not use status as a param in logs - use step_status and task_status

[wintonzheng]

Important

Rename status to step_status and task_status in agent.py and block.py for clearer logging.

• Behavior:
  • Rename status to step_status in update_step() in agent.py.
  • Rename status to task_status in update_task() in agent.py.
  • Rename status to task_status in a logging statement in execute() in block.py.

^{This description was created by for 0a3ca6f. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 0a3ca6f in 30 seconds

More details

• Looked at 35 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skyvern/forge/sdk/workflow/models/block.py:1

• Draft comment:
  No issues: This file does not use 'status' as a log parameter inappropriately. Everything looks good.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

2. skyvern/forge/agent.py:1927

• Draft comment:
  Good change – using 'step_status' instead of 'status' in logging improves clarity. Ensure that downstream log parsing is updated accordingly.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. skyvern/forge/agent.py:1980

• Draft comment:
  Similarly, replacing 'status' with 'task_status' in update_task logging is clear. Confirm that all components reflecting task status are updated.
• Reason this comment was not posted:
  Comment did not seem useful.

4. skyvern/forge/sdk/workflow/models/block.py:1

• Draft comment:
  No changes needed here. The file follows best practices and uses descriptive parameter names. Ensure consistency with updated log parameter names if referenced in related modules.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

Workflow ID: wflow_fsKVQhDR6kLd7g22

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.