Rename thinking to thought in timeline #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Change text from 'Thinking' to 'Thought' in `ThoughtCard.tsx`. > > - **UI Text Change**: > - In `ThoughtCard.tsx`, change text from 'Thinking' to 'Thought' within the `ThoughtCard` component. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 7543e788622d675f4c0303d7e21e9c580d6edbb1. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9979b70 in 9 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/ThoughtCard.tsx:41
- Draft comment:
Rename updated from 'Thinking' to 'Thought' seems correct and consistent with naming. - Reason this comment was not posted:
Confidence changes required:0%
None
2. skyvern-frontend/src/routes/workflows/workflowRun/ThoughtCard.tsx:41
- Draft comment:
Updated label to 'Thought' to match the new naming convention. - Reason this comment was not posted:
Confidence changes required:0%
None
Workflow ID: wflow_au3ro0kdLuBifqxT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9979b70 in 16 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/ThoughtCard.tsx:41
- Draft comment:
Changed label from 'Thinking' to 'Thought'. - Reason this comment was not posted:
Confidence changes required:0%
None
2. skyvern-frontend/src/routes/workflows/workflowRun/ThoughtCard.tsx:41
- Draft comment:
Renamed text label from 'Thinking' to 'Thought'. Confirm that this change is consistent with the intended UI language and other components. - Reason this comment was not posted:
Confidence changes required:0%
None
Workflow ID: wflow_uRQgQF4MHFl4SzMs
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Change text from 'Thinking' to 'Thought' in
ThoughtCardcomponent inThoughtCard.tsx.ThoughtCard.tsx, change text from 'Thinking' to 'Thought' within theThoughtCardcomponent.This description was created by
for 9979b70. It will automatically update as commits are pushed.