Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runnable type and runnable id nullable #1495

Merged

Conversation

satansdeer
Copy link
Contributor

@satansdeer satansdeer commented Jan 6, 2025

Important

Make runnable_type, runnable_id, and browser_id nullable in persistent_browser_sessions table and model.

  • Database Migration:
    • Adds browser_id column to persistent_browser_sessions table, nullable.
    • Alters runnable_type and runnable_id columns in persistent_browser_sessions table to be nullable.
  • Model Changes:
    • Updates PersistentBrowserSessionModel in models.py to make runnable_type, runnable_id, and browser_id nullable.

This description was created by Ellipsis for 2b571c9. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 2b571c9 in 37 seconds

More details
  • Looked at 65 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_EO61pacdBLLIlK04


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

# ### end Alembic commands ###


def downgrade() -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downgrade function does not handle existing null values for runnable_type and runnable_id. Consider adding a step to handle null values before altering the columns to be non-nullable.

@suchintan suchintan merged commit a06d323 into Skyvern-AI:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants