Add more logs and fix scheduler logic #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DimitarHristov111
commented
Aug 2, 2021
•
DimitarHristov111
commented
- Adds logs to show more information when the stage is in an unknown state and when an application is changed.
- Fixes the logic inside the scheduler to account for all apps.
maruina
reviewed
Aug 6, 2021
| @@ -173,6 +173,8 @@ func (r *ProgressiveSyncReconciler) requestsForApplicationChange(o client.Object | |||
| Namespace: pr.Namespace, | |||
| Name: pr.Name, | |||
| }}) | |||
| message := fmt.Sprintf("App name: %s; App status: %s", app.Name, &app.Status) | |||
There was a problem hiding this comment.
The whole app status is quite big, maybe we only care about the sync status and health status?
maruina
previously approved these changes
Aug 6, 2021
maruina
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.