-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use golang tools best practice (#59)
- Loading branch information
Showing
7 changed files
with
52 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,15 +13,15 @@ endif | |
|
|
||
| all: manager | ||
|
|
||
| # Make tools | ||
| .PHONY: tools | ||
| tools: | ||
| go generate -tags tools tools/tools.go | ||
|
|
||
| # Run tests | ||
| test: generate fmt vet manifests | ||
| test: tools generate fmt vet manifests | ||
| ginkgo -r --randomizeAllSpecs --randomizeSuites --failOnPending --cover -coverprofile=../coverage.out --trace --race --progress | ||
|
|
||
| install-ci: | ||
| go get -v github.com/onsi/ginkgo/ginkgo | ||
| go get -v github.com/onsi/gomega | ||
| go get -v -t ./... | ||
|
|
||
| # Build manager binary | ||
| manager: generate fmt vet | ||
| go build -o bin/manager main.go | ||
|
|
@@ -44,8 +44,8 @@ deploy: manifests | |
| kustomize build config/default | kubectl apply -f - | ||
|
|
||
| # Generate manifests e.g. CRD, RBAC etc. | ||
| manifests: controller-gen | ||
| $(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||
| manifests: | ||
| controller-gen $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||
|
|
||
| # Run go fmt against code | ||
| fmt: | ||
|
|
@@ -56,8 +56,8 @@ vet: | |
| go vet ./... | ||
|
|
||
| # Generate code | ||
| generate: controller-gen | ||
| $(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..." | ||
| generate: | ||
| controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..." | ||
|
|
||
| # Build the docker image | ||
| docker-build: test | ||
|
|
@@ -66,27 +66,3 @@ docker-build: test | |
| # Push the docker image | ||
| docker-push: | ||
| docker push ${IMG} | ||
|
|
||
| # find or download controller-gen | ||
| # download controller-gen if necessary | ||
| controller-gen: | ||
| ifeq (, $(shell which controller-gen)) | ||
| @{ \ | ||
| set -e ;\ | ||
| CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\ | ||
| cd $$CONTROLLER_GEN_TMP_DIR ;\ | ||
| go mod init tmp ;\ | ||
| go get sigs.k8s.io/controller-tools/cmd/[email protected] ;\ | ||
| rm -rf $$CONTROLLER_GEN_TMP_DIR ;\ | ||
| } | ||
| CONTROLLER_GEN=$(GOBIN)/controller-gen | ||
| else | ||
| CONTROLLER_GEN=$(shell which controller-gen) | ||
| endif | ||
|
|
||
| ginkgo: | ||
| ifeq (, $(shell which ginkgo)) | ||
| GINKGO=$(GOBIN)/ginkgo | ||
| else | ||
| GINKGO=$(shell which ginkgo) | ||
| endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // +build tools | ||
|
|
||
| // This file ensures tool dependencies are kept in sync. This is the | ||
| // recommended way of doing this according to | ||
| // https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module | ||
| // To install the following tools at the version used by this repo run: | ||
| // $ make tools | ||
| // or | ||
| // $ go generate -tags tools tools/tools.go | ||
|
|
||
| package tools | ||
|
|
||
| //go:generate go install github.com/onsi/ginkgo/ginkgo | ||
| import _ "github.com/onsi/ginkgo/ginkgo" | ||
|
|
||
| //go:generate go install sigs.k8s.io/controller-tools/cmd/controller-gen | ||
| import _ "sigs.k8s.io/controller-tools/cmd/controller-gen" |