Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Don't swallow all push output #199

Closed
wants to merge 1 commit into from
+2 −2
Closed

git: Don't swallow all push output #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion revup/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ async def process_stream(
except asyncio.IncompleteReadError as e:
line = e.partial
if not line:
if isinstance(setting, int) and setting != -1:
if isinstance(setting, int) and setting not in (-1, subprocess.PIPE, subprocess.STDOUT):
os.close(setting)
break
if setting == subprocess.PIPE:
Expand Down
2 changes: 1 addition & 1 deletion revup/topic_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ async def push_git_refs(self, uploader: str, create_local_branches: bool) -> Non
self.git_ctx.remote_name,
*push_targets,
]
await self.git_ctx.git(*push_args, stderr=subprocess.PIPE)
await self.git_ctx.git(*push_args, stdout=subprocess.STDOUT, stderr=subprocess.STDOUT)

async def query_github(self) -> None:
"""
Expand Down
Loading