upload: Fix review graph comment #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are two PRs in a relative chain where one PR's URL is a prefix of another (e.g. when PR 24 is relative to PR 2), the review graph comment will incorrectly modify the second URL by inserting '**' at the start and in the middle of the URL. This is due to the naive string replacement checking for any occurance of each URL. Fix this by searching instead for the URL followed by the review title and replacing them both at once instead of individually. This is also slightly more efficient since there are fewer strings allocated. Signed-off-by: Brian Kubisiak <[email protected]>
|
Reviews in this chain: |
jerry-skydio
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are two PRs in a relative chain where one PR's URL is a
prefix of another (e.g. when PR 24 is relative to PR 2), the review
graph comment will incorrectly modify the second URL by inserting '**'
at the start and in the middle of the URL. This is due to the naive
string replacement checking for any occurance of each URL.
Fix this by searching instead for the URL followed by the review title
and replacing them both at once instead of individually. This is also
slightly more efficient since there are fewer strings allocated.
Signed-off-by: Brian Kubisiak [email protected]