-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: Pin black version #144
Conversation
Reviews in this chain: |
|
Black keeps updating in the background and breaking our CI due to slightly different formatting between versions. Fix this by pinning the version.
87d4e61
to
f827cf8
Compare
f827cf8
to
676c088
Compare
Makefile
Outdated
$(PYTHON) -m pip install .[dev] | ||
$(PYTHON) -m pip install . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry .[dev]
includes installing .
, you shouldn't need both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pip has no way afaik to just install dependencies of a package, which is incredibly silly
676c088
to
aa826f6
Compare
Black keeps updating in the background and breaking our
CI due to slightly different formatting between versions.
Fix this by pinning the version.