Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: Pin black version #144

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

jerry-skydio
Copy link
Collaborator

Black keeps updating in the background and breaking our
CI due to slightly different formatting between versions.
Fix this by pinning the version.

@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
#144 makefile: Pin black version

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Jan 29, 2024

# head base diff date summary
0 87d4e617 8009c60c diff Jan 29 10:32 AM 1 file changed, 1 insertion(+), 1 deletion(-)
1 f827cf87 7df39f05 rebase Jan 29 10:37 AM 0 files changed
2 676c0885 7df39f05 diff Feb 2 11:17 AM 2 files changed, 2 insertions(+), 2 deletions(-)
3 aa826f6b 7df39f05 diff Feb 2 11:28 AM 1 file changed, 1 deletion(-)

Black keeps updating in the background and breaking our
CI due to slightly different formatting between versions.
Fix this by pinning the version.
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/pinblack branch from f827cf8 to 676c088 Compare February 2, 2024 19:18
Makefile Outdated
Comment on lines 9 to 10
$(PYTHON) -m pip install .[dev]
$(PYTHON) -m pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry .[dev] includes installing ., you shouldn't need both

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pip has no way afaik to just install dependencies of a package, which is incredibly silly

@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/pinblack branch from 676c088 to aa826f6 Compare February 2, 2024 19:28
@jerry-skydio jerry-skydio merged commit d0f24bd into main Feb 2, 2024
5 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/pinblack branch February 2, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants