git: Don't swallow all push output

Topic: outp
Skydio · Dec 28, 2024 · 8da330e · 8da330e
1 parent c7b92e8
commit 8da330e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/revup/shell.py b/revup/shell.py
@@ -69,7 +69,7 @@ async def process_stream(
         except asyncio.IncompleteReadError as e:
             line = e.partial
         if not line:
-            if isinstance(setting, int) and setting != -1:
+            if isinstance(setting, int) and setting not in (-1, subprocess.PIPE, subprocess.STDOUT):
                 os.close(setting)
             break
         if setting == subprocess.PIPE:

diff --git a/revup/topic_stack.py b/revup/topic_stack.py
@@ -1039,7 +1039,7 @@ async def push_git_refs(self, uploader: str, create_local_branches: bool) -> Non
                 self.git_ctx.remote_name,
                 *push_targets,
             ]
-            await self.git_ctx.git(*push_args, stderr=subprocess.PIPE)
+            await self.git_ctx.git(*push_args, stdout=subprocess.STDOUT, stderr=subprocess.STDOUT)
 
     async def query_github(self) -> None:
         """