Skip to content

Commit

Permalink
upload: Check PRs merge into base branch rather than base ref
Browse files Browse the repository at this point in the history
The logic for checking whether a PR was improperly merged was allowing
the target branch name, which could be a relative branch. We don't want
that, we only want changes to merge into the base branch of the entire chain.

This also helps handle some reordering issues.

Topic: reorder3
Reviewers: aaron, brian-k
  • Loading branch information
jerry-skydio committed Jan 2, 2025
1 parent 2bcb09f commit 08c642d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions revup/topic_stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -733,11 +733,11 @@ async def mark_rebases(self, skip_rebase: bool) -> None:
if (
review.status == PrStatus.MERGED
and review.pr_info is not None
and review.remote_base != review.pr_info.baseRef
and self.git_ctx.remove_branch_prefix(base_branch) != review.pr_info.baseRef
):
logging.warning(
f"Branch {review.remote_head} was merged into {review.pr_info.baseRef} "
f"instead of {review.remote_base} as expected!"
f"instead of {base_branch} as expected!"
)
# NOTE: This may not iteract well with the check at the end of create_commits
# but they are both corner cases and the worst that could happen is we fail to
Expand Down

0 comments on commit 08c642d

Please sign in to comment.