FAI-2378 Reduce spacing on multiple locations on the Vacancy details page #284
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated address display for "MultipleLocations" in both views. - Replaced traditional `foreach` with Razor `@foreach` syntax. - Improved readability while maintaining functionality. - Ensured proper HTML structure by repositioning `</ul>` tag. - Enhanced code consistency across related files. Changes made by Balaji Jambulingam
|
Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95 |
- Change output.TagName from "li" to "span" when Flat is true. - Retain output.TagName as "p" when Flat is false. - Adjusts rendered HTML structure based on Flat condition. - Reflects design decision for better semantic usage. - Ensures consistent styling with new tag structure. Changes made by Balaji Jambulingam
|
Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95 |
- Wrap each address in a <li> element for better structure. - Use an unordered list (<ul>) to enhance readability. - Ensure compliance with HTML standards for list items. - Update both _ClosedVacancyWhenAuthenticated.cshtml and _LiveVacancy.cshtml. - Improve user experience by clearly listing available locations. Changes made by Balaji Jambulingam
|
Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95 |
killij
approved these changes
Feb 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Refactor address display in location listings
foreachwith Razor@foreachsyntax.</ul>tag.Changes made by Balaji Jambulingam
Screen Grabs: Anon & Multi-city ML
