Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAI-2253 Ensure user input formatting is retained #280

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

balaji-j
Copy link
Contributor

✨ Refactor view models and Razor views for better formatting

  • Added System.ComponentModel.DataAnnotations namespace to view models.
  • Introduced [DataType(DataType.MultilineText)] for multiline text inputs.
  • Removed properties from TrainingCoursesSummaryViewModel.
  • Updated Razor views to use <pre> tags for improved text formatting.
  • Restructured HTML in delete confirmation pages for better readability.

- Added `System.ComponentModel.DataAnnotations` namespace to view models.
- Introduced `[DataType(DataType.MultilineText)]` for multiline text inputs.
- Removed properties from `TrainingCoursesSummaryViewModel`.
- Updated Razor views to use `<pre>` tags for improved text formatting.
- Restructured HTML in delete confirmation pages for better readability.

Changes made by Balaji Jambulingam
@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95

- Replaced <pre class="govuk-body"> with <div class="faa-user-content">.
- Enhanced styling and presentation of descriptions and answers.
- Improved consistency across multiple Razor view files.
- Affected files: ViewApplication.cshtml, Summary.cshtml, Preview.cshtml,
  DeleteVolunteeringOrWorkExperience.cshtml, DeleteJob.cshtml, Index.cshtml.

Changes made by Balaji Jambulingam
@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95

- Introduced `QualificationOrder` property to various qualification models.
- Updated collections in query results to order by `QualificationOrder`.
- Modified API response models to include `QualificationOrder`.
- Adjusted JSON test files to reflect the new `QualificationOrder` field.
- Enhanced view models to support displaying `QualificationOrder`.

Changes made by Balaji Jambulingam
@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @balaji-j. cc/ @ecarroll95

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants