Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QF-1181 Lower log level from error to info on ULN - Standard mismatches #1473

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

QF-1181 Lower log level from error to info on ULN - Standard mismatches #1473

wants to merge 13 commits into from

Conversation

PeterDavidWilliams
Copy link
Contributor

Also added to existing unit test to confirm correct log level and message is logged

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

ChrisJWoodcock
ChrisJWoodcock requested changes Mar 30, 2023
View reviewed changes
src/SFA.DAS.AssessorService.Application.Api/SFA.DAS.AssessorService.Application.Api.csproj Outdated
@@ -29,9 +29,9 @@
<PackageReference Include="Swashbuckle.AspNetCore.Swagger" Version="6.5.0" />
<PackageReference Include="System.ServiceModel.Duplex" Version="4.10.0" />
<PackageReference Include="System.ServiceModel.Federation" Version="4.10.*" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove package System.ServiceModel.Federation and restore others to 4.10.0

@das-github-app
Copy link

das-github-app bot commented Apr 3, 2023

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Apr 6, 2023

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented May 4, 2023

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@das-github-app
Copy link

das-github-app bot commented Jun 9, 2023

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@das-github-app
Copy link

das-github-app bot commented Dec 5, 2023

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@das-github-app
Copy link

das-github-app bot commented Feb 6, 2024

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @PeterDavidWilliams. cc/ @ecarroll95

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJWoodcock ChrisJWoodcock ChrisJWoodcock approved these changes

@Jordan-fujitsu Jordan-fujitsu Awaiting requested review from Jordan-fujitsu

@LACrossley LACrossley Awaiting requested review from LACrossley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeterDavidWilliams @ChrisJWoodcock @reachash @GPeterThomas