Merge pull request #1629 from SkillsFundingAgency/P2-2241_Remove_apar…

…_summary P2-2241 Remove the apar summary
SkillsFundingAgency · Dec 10, 2024 · 9f68662 · 9f68662
2 parents e87af4f + 1d16f6a
commit 9f68662
Show file tree

Hide file tree

Showing 30 changed files with 34 additions and 1,530 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,7 +1,7 @@
 # CODEOWNERS file for das-assessor-service
 
 # The following users will be automatically added as Reviewers to all PRs.
-* @ChrisJWoodcock @karen-hanna @LACrossley
+* @ChrisJWoodcock @karen-hanna
 
 .github/CODEOWNERS      @SkillsFundingAgency/das-platform-engineering
 /azure/                 @SkillsFundingAgency/das-platform-engineering

diff --git a/src/SFA.DAS.AssessorService.Api.Types/Models/AO/AparSummary.cs b/src/SFA.DAS.AssessorService.Api.Types/Models/AO/AparSummary.cs
diff --git a/src/SFA.DAS.AssessorService.Api.Types/Models/AparSummaryUpdateRequest.cs b/src/SFA.DAS.AssessorService.Api.Types/Models/AparSummaryUpdateRequest.cs
diff --git a/src/SFA.DAS.AssessorService.Api.Types/Models/GetAparSummaryLastUpdatedRequest.cs b/src/SFA.DAS.AssessorService.Api.Types/Models/GetAparSummaryLastUpdatedRequest.cs
diff --git a/src/SFA.DAS.AssessorService.Api.Types/Models/GetAparSummaryRequest.cs b/src/SFA.DAS.AssessorService.Api.Types/Models/GetAparSummaryRequest.cs
diff --git a/...rService.Application.Api.UnitTests/Controllers/Register/Command/AparSummaryUpdateTests.cs b/...rService.Application.Api.UnitTests/Controllers/Register/Command/AparSummaryUpdateTests.cs
diff --git a/...ce.Application.Api.UnitTests/Controllers/Register/Query/GetAparSummaryLastUpdatedTests.cs b/...ce.Application.Api.UnitTests/Controllers/Register/Query/GetAparSummaryLastUpdatedTests.cs
diff --git a/...sessorService.Application.Api.UnitTests/Controllers/Register/Query/GetAparSummaryTests.cs b/...sessorService.Application.Api.UnitTests/Controllers/Register/Query/GetAparSummaryTests.cs
diff --git a/src/SFA.DAS.AssessorService.Application.Api/Controllers/RegisterQueryController.cs b/src/SFA.DAS.AssessorService.Application.Api/Controllers/RegisterQueryController.cs
@@ -64,27 +64,6 @@ public async Task<IActionResult> GetAssessmentOrganisations()
             return Ok(await _mediator.Send(new GetAssessmentOrganisationsRequest()));
         }
 
-        [HttpGet("assessment-organisations/apar-summary", Name = "GetAPARSummary")]
-        [SwaggerResponse((int)HttpStatusCode.OK, Type = typeof(List<AparSummary>))]
-        [SwaggerResponse((int)HttpStatusCode.BadRequest, Type = typeof(IDictionary<string, string>))]
-        [SwaggerResponse((int)HttpStatusCode.InternalServerError, Type = typeof(ApiResponse))]
-        public async Task<IActionResult> GetAparSummary()
-        {
-            _logger.LogInformation("Get APAR Summary");
-            return Ok(await _mediator.Send(new GetAparSummaryRequest()));
-        }
-
-        [HttpGet("assessment-organisations/apar-summary/{ukprn}", Name = "GetAparSummaryByUkprn")]
-        [SwaggerResponse((int)HttpStatusCode.OK, Type = typeof(AparSummary))]
-        [SwaggerResponse((int)HttpStatusCode.BadRequest, Type = typeof(IDictionary<string, string>))]
-        [SwaggerResponse((int)HttpStatusCode.InternalServerError, Type = typeof(ApiResponse))]
-        public async Task<IActionResult> GetAparSummaryByUkprn(int ukprn)
-        {
-            _logger.LogInformation($"Get Apar Summary by UKPRN [{ukprn}]");
-            var results = await _mediator.Send(new GetAparSummaryRequest(ukprn));
-            return Ok(results.FirstOrDefault());
-        }
-
         [HttpGet("assessment-organisations/{organisationId}", Name = "GetAssessmentOrganisation")]
         [SwaggerResponse((int) HttpStatusCode.OK, Type = typeof(EpaOrganisation))]
         [SwaggerResponse((int) HttpStatusCode.NotFound, null)]
@@ -239,30 +218,6 @@ public async Task<IActionResult> SearchStandards(string searchstring)
 
             return Ok(results.Select(s => (StandardVersion)s).ToList());
         }
-
-        [HttpPost("assessment-organisations/apar-summary-update", Name = "APARSummaryUpdate")]
-        [SwaggerResponse((int)HttpStatusCode.Accepted, Type = typeof(int?))]
-        [SwaggerResponse((int)HttpStatusCode.InternalServerError, Type = typeof(ApiResponse))]
-        public IActionResult AparSummaryUpdate()
-        {
-            var requestName = "update APAR summary";
-            return QueueBackgroundRequest(new AparSummaryUpdateRequest(), requestName, (response, duration, log) =>
-            {
-                var result = response;
-                log.LogInformation($"Completed request to {requestName}, there were {result} changes made to APAR for EPAOs in {duration.ToReadableString()}");
-            });
-        }
-
-        [HttpGet("assessment-organisations/apar-summary-last-updated", Name = "GetAparSummaryLastUpdated")]
-        [SwaggerResponse((int)HttpStatusCode.OK, Type = typeof(List<DateTime>))]
-        [SwaggerResponse((int)HttpStatusCode.BadRequest, Type = typeof(IDictionary<string, string>))]
-        [SwaggerResponse((int)HttpStatusCode.InternalServerError, Type = typeof(ApiResponse))]
-        public async Task<IActionResult> GetAparSummaryLastUpdated()
-        {
-            _logger.LogInformation("Getting APAR Summary Last Updated Date");
-
-            return Ok(await _mediator.Send(new GetAparSummaryLastUpdatedRequest()));
-        }
     }
 }
 
diff --git a/...vice.Application.UnitTests/Handlers/Register/Query/RegisterQueryAparSummaryUpdateTests.cs b/...vice.Application.UnitTests/Handlers/Register/Query/RegisterQueryAparSummaryUpdateTests.cs