rpc: checkblock, add checkBlock() to Mining interface #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this can be useful for Sv2 JDS to check template validity cc @GitGab19 |
Co-authored-by: Greg Sanders <[email protected]>
Sjors
force-pushed
the
2024/12/check-block
branch
from
146459b to
02801f1
Compare
|
Simplified things by just calling |
Sjors
force-pushed
the
2024/12/check-block
branch
4 times, most recently
from
972f752 to
022f4be
Compare
|
Also added |
Sjors
changed the title
Sjors
force-pushed
the
2024/12/check-block
branch
2 times, most recently
from
ef49610 to
768e0db
Compare
|
I got rid of Would be nice if someone can demonstrate usage of the new RPC. E.g. the SRI Job Declarator Server could call it from here: https://github.com/stratum-mining/stratum/blob/main/roles/jd-server/src/lib/job_declarator/message_handler.rs#L204 |
Alternate calls between Chainman's ProcessNewBlock and submitSolution. The Chainman code path is used in production, so it's important to keep test coverage for it. Use createNewBlock via the interface instead of using the BlockAssembler directly. The latter is always called via the interface in production code.
Sjors
force-pushed
the
2024/12/check-block
branch
from
768e0db to
442f27a
Compare
|
Further cleanup. |
|
Moving to bitcoin#31564. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC and IPC for checking weak blocks (reduced proof of work) and block templates (no proof of work) against all consensus rules.
Uses the first test commit from bitcoin#31283 to refactor
miner_tests.cpp.