Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs][sitecore-jss] Improve Chromes mode fetching #2019

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jan 27, 2025

Description / Motivation

Alternative fix for Chromes mode issues. Makes https request when in XMC, Vercel or Netlify hosting.

Previous approach #2018

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 27, 2025 14:26
@art-alexeyenko art-alexeyenko changed the title [sitecore-jss-nextjs][sitecore-jss] Improve Chrome fetching [sitecore-jss-nextjs][sitecore-jss] Improve Chromes mode fetching Jan 27, 2025
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@art-alexeyenko art-alexeyenko merged commit d160f10 into dev Jan 27, 2025
1 check passed
@art-alexeyenko art-alexeyenko deleted the bug/jss-4940-chromes-fix-2 branch January 27, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants