[sitecore-jss]: The logic of method escapeNonSpecialQuestionMarks has been fixed #SXA-7975 #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2025 16:20
yavorsk
deleted the
bugfix/SXA-7975-fix-method-escape-special-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This fix for the
escapeNonSpecialQuestionMarksfunction to correctly handle negative lookaheads. Previously, the function incorrectly escaped?within negative lookahead patterns like(?!). Now, the logic ensures that?inside these constructs remains unescaped while still escaping other unescaped question marks outside special regex constructs.Testing Details
Types of changes