Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-dev-tools] Reuse Node.js ClientRequest for package deploy process #2013

Merged
merged 9 commits into from
Jan 22, 2025
Merged

[sitecore-jss-dev-tools] Reuse Node.js ClientRequest for package deploy process #2013

merged 9 commits into from
Jan 22, 2025

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 21, 2025 •
edited by addy-pathania
Loading

Description / Motivation

Utilized the native Node.js ClientRequest API to enable more customized configurations for request agents, file streaming, and certificate pinning

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team January 21, 2025 19:07
art-alexeyenko
art-alexeyenko requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot to address, looks solid and seem to work. Let's ensure this change is as good as it can be.

packages/sitecore-jss-dev-tools/src/package-deploy.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-dev-tools/src/package-deploy.test.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 49e56a9 into dev Jan 22, 2025
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-4908 branch January 22, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illiakovalenko @art-alexeyenko @apathania22