Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template/nextjs-sxa] Fix ReadableStream compilation error #2008

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[template/nextjs-sxa] Fix ReadableStream compilation error #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3176cff
fix readbale stream error
apathania22 Jan 16, 2025
9185895
update changelog
apathania22 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Our versioning strategy is as follows:

### 🛠 Breaking Change

* `[all packages]` `[all samples]` Remove Axios ([#2006](https://github.com/Sitecore/jss/pull/2006))
* `[all packages]` `[all samples]` Remove Axios ([#2006](https://github.com/Sitecore/jss/pull/2006)) ([#2008](https://github.com/Sitecore/jss/pull/2008))
* `AxiosDataFetcher` is replaced by the `NativeDataFetcher`.
* `AxiosDataFetcherConfig` is replaced by `NativeDataFetcherConfig`.
* `AxiosResponse` is replaced by `NativeDataFetcherResponse`.
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const sitemapApi = async (
const fetcher = new NativeDataFetcher();
const response = await fetcher.fetch(sitemapUrl);

const reader = response.data?.getReader();
const reader = (response?.data as ReadableStream<Uint8Array>).getReader();
if (reader) {
while (true) {
const { done, value } = await reader.read();
Expand Down