Fixes some upgrader errors #8437

Sesquipedalian · 2025-02-04T22:35:33Z

@sbulen, this should fix the unrelated issues that you ran into while testing #8425. Please test this PR first. Once we have merged this, we can go back to testing #8425.

Also fixes #8439

Signed-off-by: Jon Stovell <[email protected]>

sbulen · 2025-02-04T23:34:23Z

I can get much closer to running a simple 2.1.4 => 3.0 upgrade. Still an outstanding issue though.

PHP 8.4.2; MySQL 8.4.0; Upgrader run via CLI.

Partial log:

+++ Adding the new table for alerts. done.
+++ Adding alert preferences. done.
+++ Upgrading post notification settings done.
+++ Dropping old notification fields from the members table done.
+++ Upgrading auto notify settingError: Trying to access array offset on null File: D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code Line: 6
Fatal error: Uncaught Error: Value of type null is not callable in D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code on line 6

Error: Value of type null is not callable in D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code on line 6

Call Stack:
0.0080 1402856 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
0.2671 5946840 2. DatabaseChanges() D:\wamp64\www\van2130\upgrade.php:371
0.2685 5948472 3. parse_sql($filename = 'D:\wamp64\www\van2130/upgrade_2-1_MySQL.sql') D:\wamp64\www\van2130\upgrade.php:1886
1.0210 6782520 4. eval('D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code') D:\wamp64\www\van2130\upgrade.php:2512

Signed-off-by: Jon Stovell <[email protected]>

sbulen · 2025-02-04T23:41:02Z

Note I attempted to run the installer and got a WSOD with :

Invalid data structure sent to the database.

The WSOD happened in the very last step, creating the admin account.

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian · 2025-02-04T23:45:38Z

I can get much closer to running a simple 2.1.4 => 3.0 upgrade. Still an outstanding issue though.

There were some leftover $smcFunc['db_*'] calls. Should be fixed in 1032ac3.

Note I attempted to run the installer and got a WSOD with :

Invalid data structure sent to the database.

The WSOD happened in the very last step, creating the admin account.

Should be fixed in 3b8a2c9.

sbulen · 2025-02-04T23:59:05Z

OK.... Ran a few tests...

Installer worked perfectly PHP8.4/Mysql 8.4
The upgrader failed, both in PHP8.3 & PHP8.4, with different errors....

Upgrader error in PHP 8.4 (partial CLI output log):

+++ Adding support for recurring events... done.
+++ Migrate holidays to eventsError: Passing E_USER_ERROR to trigger_error() is deprecated since 8.4, throw an exception or call exit with a string message instead File: D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php Line: 2406Error: Invalid data structure sent to the database.(Event.php-720) File: D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php Line: 2406
Fatal error: Uncaught TypeError: array_combine(): Argument #2 ($values) must be of type array, string given in D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php on line 396

TypeError: array_combine(): Argument #2 ($values) must be of type array, string given in D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php on line 396

Call Stack:
0.0076 1402856 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
1.5521 5946840 2. DatabaseChanges() D:\wamp64\www\van2130\upgrade.php:371
5.8278 6489816 3. parse_sql($filename = 'D:\wamp64\www\van2130/upgrade_3-0_MySQL.sql') D:\wamp64\www\van2130\upgrade.php:1886
7.3730 6675128 4. eval('D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code') D:\wamp64\www\van2130\upgrade.php:2512
7.4552 8570736 5. SMF\Calendar\Event->save() D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code:612
7.4554 8572288 6. SMF\Db\APIs\MySQL->insert($method = '', $table = '{db_prefix}calendar', $columns = ['start_date' => 'date', 'end_date' => 'date', 'id_board' => 'int', 'id_topic' => 'int', 'title' => 'string-255', 'id_member' => 'int', 'location' => 'string-255', 'duration' => 'string-32', 'rrule' => 'string', 'rdates' => 'string', 'exdates' => 'string', 'adjustments' => 'string', 'sequence' => 'int', 'uid' => 'string-255', 'type' => 'int', 'enabled' => 'int'], $data = [0 => '2000-04-01', 1 => '9999-12-31', 2 => 0, 3 => 0, 4 => 'April Fools' Day', 5 => 0, 6 => '', 7 => 'P1D', 8 => 'FREQ=YEARLY', 9 => '', 10 => '', 11 => '[]', 12 => 0, 13 => '0194d360-a431-7959-8175-205ada6cb09f', 14 => 1, 15 => 1], $keys = [0 => 'id_event'], $returnmode = 1, $connection = ???) D:\wamp64\www\van2130\Sources\Calendar\Event.php:720
7.4555 8573088 7. array_combine($keys = [0 => 'start_date', 1 => 'end_date', 2 => 'id_board', 3 => 'id_topic', 4 => 'title', 5 => 'id_member', 6 => 'location', 7 => 'duration', 8 => 'rrule', 9 => 'rdates', 10 => 'exdates', 11 => 'adjustments', 12 => 'sequence', 13 => 'uid', 14 => 'type', 15 => 'enabled'], $values = '2000-04-01') D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php:396

Upgrader error in PHP8.3 (partial CLI output log):

+++ Adding support for recurring events... done.
. +++ Migrate holidays to eventsError: Invalid data structure sent to the database.(Event.php-720) File: D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php Line: 2406
Fatal error: Uncaught TypeError: array_combine(): Argument #2 ($values) must be of type array, string given in D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php on line 396

TypeError: array_combine(): Argument '#`2 ($values) must be of type array, string given in D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php on line 396

Call Stack:
0.0074 1579224 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
0.2461 5882408 2. DatabaseChanges() D:\wamp64\www\van2130\upgrade.php:371
4.7161 6420192 3. parse_sql($filename = 'D:\wamp64\www\van2130/upgrade_3-0_MySQL.sql') D:\wamp64\www\van2130\upgrade.php:1886
6.2966 6605496 4. eval('D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code') D:\wamp64\www\van2130\upgrade.php:2512
6.3760 8367696 5. SMF\Calendar\Event->save() D:\wamp64\www\van2130\upgrade.php(2512) : eval()'d code:612
6.3761 8369240 6. SMF\Db\APIs\MySQL->insert($method = '', $table = '{db_prefix}calendar', $columns = ['start_date' => 'date', 'end_date' => 'date', 'id_board' => 'int', 'id_topic' => 'int', 'title' => 'string-255', 'id_member' => 'int', 'location' => 'string-255', 'duration' => 'string-32', 'rrule' => 'string', 'rdates' => 'string', 'exdates' => 'string', 'adjustments' => 'string', 'sequence' => 'int', 'uid' => 'string-255', 'type' => 'int', 'enabled' => 'int'], $data = [0 => '2000-04-01', 1 => '9999-12-31', 2 => 0, 3 => 0, 4 => 'April Fools' Day', 5 => 0, 6 => '', 7 => 'P1D', 8 => 'FREQ=YEARLY', 9 => '', 10 => '', 11 => '[]', 12 => 0, 13 => '0194d364-463b-72b7-864c-b38157e0431b', 14 => 1, 15 => 1], $keys = [0 => 'id_event'], $returnmode = 1, $connection = ???) D:\wamp64\www\van2130\Sources\Calendar\Event.php:720
6.3762 8370040 7. array_combine($keys = [0 => 'start_date', 1 => 'end_date', 2 => 'id_board', 3 => 'id_topic', 4 => 'title', 5 => 'id_member', 6 => 'location', 7 => 'duration', 8 => 'rrule', 9 => 'rdates', 10 => 'exdates', 11 => 'adjustments', 12 => 'sequence', 13 => 'uid', 14 => 'type', 15 => 'enabled'], $values = '2000-04-01') D:\wamp64\www\van2130\Sources\Db\APIs\MySQL.php:396

sbulen · 2025-02-05T00:10:21Z

Let me know if you want me to focus testing on PHP8.3.

The PHP8.4 issue is tracked separately here: #8402

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian · 2025-02-05T00:38:56Z

Error: Invalid data structure sent to the database.(Event.php-720)

c469228 should fix that. I think I have found all the places that would have triggered that error now.

Let me know if you want me to focus testing on PHP8.3.

The PHP8.4 issue is tracked separately here: #8402

Once we have fixed the underlying issues so that no more error are triggered, we won't see that one either. We can deal with #8402 itself separately.

sbulen · 2025-02-05T02:44:59Z

OK here's the latest:

Installer runs to completion.
The 2.1 => 3.0 upgrade appears to run to completion, BUT, some "cleanup" steps are reporting errors. Forum is functional.

Note the "The process cannot access the file because it is being used by another process (code: 32)" must be related to this upgrade - it's the only thing running.

Also.... up.txt is the name of my CLI output log, where messages are being piped, it's not an SMF file...

Upgrade test, PHP8.3, partial CLI log:

+++ Adding a new column "spoofdetector_name" to members table done.
. +++ Adding new "spoofdetector_censor" setting done.
Successful.

+++ Adding a new column "smf_version" to log_packages table done.
Successful.

Warning: Trying to access array offset on null in D:\wamp64\www\van2130\upgrade.php on line 4086

Call Stack:
0.0126 1579224 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
9.1089 8469928 2. serialize_to_json() D:\wamp64\www\van2130\upgrade.php:371
9.1089 8555944 3. ConvertUtf8() D:\wamp64\www\van2130\upgrade.php:3801
9.1305 8555944 4. Cleanup() D:\wamp64\www\van2130\upgrade.php:3201

Cleaning up.
Warning: Trying to access array offset on null in D:\wamp64\www\van2130\upgrade.php on line 4102

Call Stack:
0.0126 1579224 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
9.1089 8469928 2. serialize_to_json() D:\wamp64\www\van2130\upgrade.php:371
9.1089 8555944 3. ConvertUtf8() D:\wamp64\www\van2130\upgrade.php:3801
9.1305 8555944 4. Cleanup() D:\wamp64\www\van2130\upgrade.php:3201

+++ Clean up ""... done.
Warning: Trying to access array offset on null in D:\wamp64\www\van2130\upgrade.php on line 4102

Call Stack:
0.0126 1579224 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
9.1089 8469928 2. serialize_to_json() D:\wamp64\www\van2130\upgrade.php:371
9.1089 8555944 3. ConvertUtf8() D:\wamp64\www\van2130\upgrade.php:3801
9.1305 8555944 4. Cleanup() D:\wamp64\www\van2130\upgrade.php:3201

+++ Clean up ""... done.
Warning: rename(D:/wamp64/www/van2130/up.txt,D:\wamp64\www\van2130/Languages/up.txt): The process cannot access the file because it is being used by another process (code: 32) in D:\wamp64\www\van2130\upgrade.php on line 4197

Call Stack:
0.0126 1579224 1. {main}() D:\wamp64\www\van2130\upgrade.php:0
9.1089 8469928 2. serialize_to_json() D:\wamp64\www\van2130\upgrade.php:371
9.1089 8555944 3. ConvertUtf8() D:\wamp64\www\van2130\upgrade.php:3801
9.1305 8555944 4. Cleanup() D:\wamp64\www\van2130\upgrade.php:3201
9.1361 8555896 5. CleanupAgreements() D:\wamp64\www\van2130\upgrade.php:4122
9.1364 8556432 6. rename($from = 'D:/wamp64/www/van2130/up.txt', $to = 'D:\wamp64\www\van2130/Languages/up.txt') D:\wamp64\www\van2130\upgrade.php:4197

Successful.

Upgrade Complete!
Please delete this file as soon as possible for security reasons.

sbulen · 2025-02-05T02:59:07Z

I just attempted a 2.0 => 3.0 upgrade, & it didn't get very far. I thought we were thinking of dropping upgrades from forums prior to 2.1???

Anyway here's the error:

Fatal error: Uncaught TypeError: Cannot assign int to property SMF\Config::$db_persist of type bool in D:\wamp64\www\van2021\Sources\Config.php on line 900

TypeError: Cannot assign int to property SMF\Config::$db_persist of type bool in D:\wamp64\www\van2021\Sources\Config.php on line 900

Call Stack:
0.0107 1402856 1. {main}() D:\wamp64\www\van2021\upgrade.php:0
0.0163 1841888 2. SMF\Config::load() D:\wamp64\www\van2021\upgrade.php:188
0.0166 1843864 3. SMF\Config::set($settings = ['maintenance' => 0, 'mtitle' => 'Maintenance Mode', 'mmessage' => 'Okay faithful users...we're attempting to restore an older backup of the database...news will be posted once we're back!', 'mbname' => 'van2021', 'language' => 'english', 'boardurl' => 'https://localhost/van2021', 'webmaster_email' => '[email protected]', 'cookiename' => 'SMFCookie332XX', 'db_type' => 'mysql', 'db_server' => 'localhost', 'db_name' => 'van2021', 'db_user' => 'admin_dude', 'db_passwd' => 'yadayada', 'ssi_db_user' => '', 'ssi_db_passwd' => '', 'db_prefix' => 'rul_', 'db_persist' => 0, 'db_error_send' => 1, 'boarddir' => 'D:\wamp64\www\van2021', 'sourcedir' => 'D:\wamp64\www\van2021/Sources', 'cachedir' => 'D:\wamp64\www\van2021/cache', 'db_last_error' => 0, 'image_proxy_secret' => 'c6d6c0756d3', 'image_proxy_maxsize' => '5190', 'image_proxy_enabled' => '0', 'auth_secret' => 'e3b4986d1087d75d636bb0b731111c']) D:\wamp64\www\van2021\Sources\Config.php:888

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian · 2025-02-05T04:57:49Z

Warning: Trying to access array offset on null in D:\wamp64\www\van2130\upgrade.php on line 4086

Warning: Trying to access array offset on null in D:\wamp64\www\van2130\upgrade.php on line 4102

These ones should be fixed by 67e0235.

Warning: rename(D:/wamp64/www/van2130/up.txt,D:\wamp64\www\van2130/Languages/up.txt): The process cannot access the file because it is being used by another process (code: 32) in D:\wamp64\www\van2130\upgrade.php on line 4197

This one should be fixed by 0015dbc.

Fatal error: Uncaught TypeError: Cannot assign int to property SMF\Config::$db_persist of type bool in D:\wamp64\www\van2021\Sources\Config.php on line 900

This one should be fixed by 1eeb801.

Sesquipedalian · 2025-02-05T05:04:07Z

I thought we were thinking of dropping upgrades from forums prior to 2.1???

Not yet. Once #8093 is done, we'll move the stuff for upgrading from SMF 1.x into separate converter packages. I plan to keep support for upgrading from SMF 2.0.x in the large upgrader package, though. We still have a lot of 2.0.x forums out there, and I want it to be easy for those admins to upgrade to 3.0 when they learn that 2.0 has reached end-of-life.

Signed-off-by: Jon Stovell <[email protected]>

sbulen · 2025-02-05T06:38:17Z

Results:

3.0 Installer still OK 🍻
2.1 to 3.0 upgrade OK 🍻
2.0 to 3.0 upgrade failed, two different errors, details below.... The parse error stopped execution.

Partial CLI log:

+++ Replacing old calendar settings... done.
+++ Deleting old calendar settings... done.
+++ Adjusting calendar maximum year... done.
+++ Adding advanced signature settings... done.
+++ Updating spam protection settings.Error: Trying to access array offset on null File: D:\wamp64\www\van2021\upgrade.php(2512) : eval()'d code Line: 16 done.
+++ Adjusting timezone settings... done.
+++ Checking theme layers are correct for default themes. done.
+++ Adding index to log_notify table... done.
+++ GDPR compliance settings. done.

Partial CLI log:

+++ Adding file hash. done.
+++ Populate the attachment extension. done.
+++ Updating thumbnail attachments JPG. done.
+++ Updating thumbnail attachments PNG. done.
+++ Calculating attachment mime types.
Parse error: syntax error, unexpected identifier "Config", expecting variable or "$" in D:\wamp64\www\van2021\upgrade.php(2512) : eval()'d code on line 16

sbulen · 2025-02-05T06:50:59Z

Still haven't tried 1.1, 1.0, or YaBBSE yet; some setups needed on my side to get all that working again.

Also haven't yet done a 3.0 => 3.0 upgrade test yet. Historical we've ensured the upgrader can be rerun, eg, for folks who encounter issues & end up restarting it a few times...

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian · 2025-02-05T07:59:25Z

2.0 to 3.0 upgrade failed, two different errors, details below.... The parse error stopped execution.

Latest two commits should fix those.

Still haven't tried 1.1, 1.0, or YaBBSE yet; some setups needed on my side to get all that working again.

Don't worry about that for now. The real target for installer and upgrader stuff is Alpha 5. The goal for Alpha 3 regarding the upgrader is just to verify that the rewritten ConvertUtf8() works correctly. Testing 2.0 → 3.0 is sufficient for that.

Sesquipedalian · 2025-02-05T07:59:57Z

Also haven't yet done a 3.0 => 3.0 upgrade test yet. Historical we've ensured the upgrader can be rerun, eg, for folks who encounter issues & end up restarting it a few times...

That's an important one for sure.

sbulen · 2025-02-05T16:14:14Z

OK, won't do 1.1, 1.0, or YaBBSE at this time.

Results:
3.0 Installer OK 🍻
3.0 to 3.0 upgrade OK 🍻
2.1 to 3.0 upgrade OK 🍻
2.0 to 3.0 upgrade failed, details below...

Partial CLI log:

+++ Adding support for recurring events... done.
. +++ Migrate holidays to events
Fatal error: Uncaught DateMalformedStringException: DateTime::modify(): Failed to parse time string (last day of June 00:00:00 Etc/GMT0) at position 33 (0): Unexpected character in D:\wamp64\www\van2021\Sources\Calendar\RecurrenceIterator.php on line 1416

DateMalformedStringException: DateTime::modify(): Failed to parse time string (last day of June 00:00:00 Etc/GMT0) at position 33 (0): Unexpected character in D:\wamp64\www\van2021\Sources\Calendar\RecurrenceIterator.php on line 1416

Call Stack:
0.0080 1402880 1. {main}() D:\wamp64\www\van2021\upgrade.php:0
0.4667 5926792 2. DatabaseChanges() D:\wamp64\www\van2021\upgrade.php:371
14.6777 6500672 3. parse_sql($filename = 'D:\wamp64\www\van2021/upgrade_3-0_MySQL.sql') D:\wamp64\www\van2021\upgrade.php:1886
16.1631 6685984 4. eval('D:\wamp64\www\van2021\upgrade.php(2512) : eval()'d code') D:\wamp64\www\van2021\upgrade.php:2512
16.2604 8659184 5. SMF\Calendar\Event->__construct($id = 0, $props = ['recurrence_end' => class SMF\Time { protected $custom = [...]; public $date = '9999-12-31 00:00:00.000000'; public $timezone_type = 3; public $timezone = 'Etc/GMT0' }, 'rrule' => 'FREQ=YEARLY;BYMONTH=6;BYDAY=3SU', 'type' => 1, 'title' => 'Father's Day', 'allday' => TRUE, 'start' => class SMF\Time { protected $custom = [...]; public $date = '2000-06-19 00:00:00.000000'; public $timezone_type = 3; public $timezone = 'Etc/GMT0' }, 'duration' => class DateInterval { public $y = 0; public $m = 0; public $d = 1; public $h = 0; public $i = 0; public $s = 0; public $f = 0; public $invert = 0; public $days = FALSE; public $from_string = FALSE }]) D:\wamp64\www\van2021\upgrade.php(2512) : eval()'d code:595
16.2606 8661240 6. SMF\Calendar\Event->createRecurrenceIterator() D:\wamp64\www\van2021\Sources\Calendar\Event.php:544
16.2606 8662568 7. SMF\Calendar\RecurrenceIterator->__construct($rrule = class SMF\Calendar\RRule { public string $freq = 'YEARLY'; public int $interval = 1; public DateTimeInterface $until = uninitialized; public int $until_type = uninitialized; public int $count = uninitialized; public array $bymonth = [0 => 6]; public array $byweekno = uninitialized; public array $byyearday = uninitialized; public array $bymonthday = uninitialized; public array $byday = [0 => '3SU']; public array $byhour = uninitialized; public array $byminute = uninitialized; public array $bysecond = uninitialized; public array $bysetpos = uninitialized; public string $wkst = 'MO' }, $dtstart = class SMF\Time { protected $custom = []; public $date = '2000-06-19 00:00:00.000000'; public $timezone_type = 3; public $timezone = 'Etc/GMT0' }, $view = class DateInterval { public $y = 1; public $m = 0; public $d = 0; public $h = 0; public $i = 0; public $s = 0; public $f = 0; public $invert = 0; public $days = 365; public $from_string = FALSE }, $view_start = class SMF\Time { protected $custom = []; public $date = '2000-06-19 00:00:00.000000'; public $timezone_type = 3; public $timezone = 'Etc/GMT0' }, $type = 2, $rdates = [], $exdates = []) D:\wamp64\www\van2021\Sources\Calendar\Event.php:2254
16.2607 8667048 8. SMF\Calendar\RecurrenceIterator->calculate() D:\wamp64\www\van2021\Sources\Calendar\RecurrenceIterator.php:437
16.2607 8671912 9. SMF\Calendar\RecurrenceIterator->expand($current = class DateTime { public $date = '2000-06-19 00:00:00.000000'; public $timezone_type = 3; public $timezone = 'Etc/GMT0' }, $break_after = NULL) D:\wamp64\www\van2021\Sources\Calendar\RecurrenceIterator.php:869
16.2607 8675752 10. SMF\Calendar\RecurrenceIterator->expandMonthByDay($current = class DateTime { public $date = '2000-06-19 00:00:00.000000'; public $timezone_type = 3; public $timezone = 'Etc/GMT0' }, $expansion_values = [0 => '3SU'], $current_value = 'MO') D:\wamp64\www\van2021\Sources\Calendar\RecurrenceIterator.php:1294
16.2607 8676136 11. DateTime->modify($modifier = 'last day of June 00:00:00 Etc/GMT0') D:\wamp64\www\van2021\Sources\Calendar\RecurrenceIterator.php:1416

Sesquipedalian · 2025-02-05T19:27:30Z

Apparently it doesn't like Etc/GMT0, even though that is supposed to be on the list of supported (albeit deprecated) time zone identifiers. That's unexpected, but not insurmountable. I'll probably add a special case in SMF\Time to replace such deprecated time zone identifiers with non-deprecated alternatives. There's already code in SMF\TimeZone to do that more generally, so it should just be a matter of applying that in a new situation.

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian · 2025-02-05T19:54:02Z

I'll probably add a special case in SMF\Time to replace such deprecated time zone identifiers with non-deprecated alternatives. There's already code in SMF\TimeZone to do that more generally, so it should just be a matter of applying that in a new situation.

... Which is not actually what I did. Instead I simply added fallbacks in SMF\Calendar\RecurrenceIterator to replace the time zone identifier with the UTC offset when the time zone identifier is not recognized by \DateTimeInterface::modify().

sbulen · 2025-02-05T23:00:52Z

OK, here are the current results, with 2 caveats:
3.0 Installer OK 🍻
3.0 to 3.0 upgrade OK 🍻
2.1 to 3.0 upgrade OK 🍻
2.0 to 3.0 upgrade OK 🍻

Caveat 1:
I normally do a compare of an install DB structure to an upgrade DB structure, to make sure they match perfectly. I figure this can wait until we test #8425 , along with the other tests, e.g., 1.0 & 1.1.

Caveat 2:
I don't THINK this is directly related, but just letting you know for awareness. I didn't do a lot of testing, but posting gives you a WSOD & logs this:

Sesquipedalian · 2025-02-05T23:56:41Z

Great! Thanks, @sbulen! We can deal with those remaining items elsewhere later.

Sesquipedalian added 3 commits February 4, 2025 15:20

Fixes what appears to be a copy-paste error

08958e1

Signed-off-by: Jon Stovell <[email protected]>

Passes well-formed data to Db::insert() in upgrader scripts

2f9717e

Signed-off-by: Jon Stovell <[email protected]>

Fix errors inserting scoped variables into strings in upgrader scripts

29a2b4d

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian added the Upgrader label Feb 4, 2025

Sesquipedalian added this to the 3.0 Alpha 3 milestone Feb 4, 2025

Sesquipedalian mentioned this pull request Feb 4, 2025

Uses UTF8MB4 everywhere #8425

Open

Replaces some leftover $smcFunc['db_*'] calls with Db::$db calls

1032ac3

Signed-off-by: Jon Stovell <[email protected]>

Passes well-formed data to Db::insert() in install script

3b8a2c9

Signed-off-by: Jon Stovell <[email protected]>

Passes well-formed data to Db::insert() in a few last places

c469228

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian added 3 commits February 4, 2025 21:13

Use Lang::$txt, not global $txt, in upgrader's Cleanup()

67e0235

Signed-off-by: Jon Stovell <[email protected]>

Fixes incorrect test in upgrader's CleanupAgreements()

0015dbc

Signed-off-by: Jon Stovell <[email protected]>

Attempts to cast settings to the expected type in Config::set()

1eeb801

Signed-off-by: Jon Stovell <[email protected]>

Passes well-formed data to Db::insert() in Actions\Display::markRead()

edc03bb

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian mentioned this pull request Feb 5, 2025

[3.0]: "Invalid data structure" error when trying to view a topic #8439

Closed

Sesquipedalian added 2 commits February 5, 2025 00:43

Fix more errors inserting scoped vars into strings in upgrader scripts

f14bbe8

Signed-off-by: Jon Stovell <[email protected]>

Removes a stray global statement in upgrader script

cda9d33

Signed-off-by: Jon Stovell <[email protected]>

Adds fallbacks in RecurrenceIterator for deprecated time zones

4c76753

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian merged commit 4a12e48 into SimpleMachines:release-3.0 Feb 5, 2025
6 checks passed

Sesquipedalian deleted the 3.0/upgrader branch February 6, 2025 01:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes some upgrader errors #8437

Fixes some upgrader errors #8437

Sesquipedalian commented Feb 4, 2025 •

edited

Loading

sbulen commented Feb 4, 2025

sbulen commented Feb 4, 2025 •

edited

Loading

Sesquipedalian commented Feb 4, 2025

sbulen commented Feb 4, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025

sbulen commented Feb 5, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025

Sesquipedalian commented Feb 5, 2025

sbulen commented Feb 5, 2025

sbulen commented Feb 5, 2025

Sesquipedalian commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025

sbulen commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025

Fixes some upgrader errors #8437

Fixes some upgrader errors #8437

Conversation

Sesquipedalian commented Feb 4, 2025 • edited Loading

sbulen commented Feb 4, 2025

sbulen commented Feb 4, 2025 • edited Loading

Sesquipedalian commented Feb 4, 2025

sbulen commented Feb 4, 2025 • edited Loading

sbulen commented Feb 5, 2025 • edited Loading

Sesquipedalian commented Feb 5, 2025

sbulen commented Feb 5, 2025 • edited Loading

sbulen commented Feb 5, 2025 • edited Loading

Sesquipedalian commented Feb 5, 2025

Sesquipedalian commented Feb 5, 2025

sbulen commented Feb 5, 2025

sbulen commented Feb 5, 2025

Sesquipedalian commented Feb 5, 2025 • edited Loading

Sesquipedalian commented Feb 5, 2025

sbulen commented Feb 5, 2025 • edited Loading

Sesquipedalian commented Feb 5, 2025 • edited Loading

Sesquipedalian commented Feb 5, 2025 • edited Loading

sbulen commented Feb 5, 2025 • edited Loading

Sesquipedalian commented Feb 5, 2025

Sesquipedalian commented Feb 4, 2025 •

edited

Loading

sbulen commented Feb 4, 2025 •

edited

Loading

sbulen commented Feb 4, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025 •

edited

Loading

Sesquipedalian commented Feb 5, 2025 •

edited

Loading

sbulen commented Feb 5, 2025 •

edited

Loading