G11 #24
Closed
G11 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Sprite
|
|
|
RSI Diff Bot; head commit d44ec1f merging into faa2072 Resources/Textures/SimpleStation14/weapons/G11.rsi
|
|
I had a revelation in the shower, i should add firerate, to decrease the between burst time |
|
I will also add it to deltav |
|
|
|
Its already fixed |
Push the fix then, current version is supposedly invalid |
|
i fixed it |
|
let me test something first then we can merge it |
|
this is ready to pr |
Plyushsune
requested review from
Pspritechologist and
DEATHB4DEFEAT
as code owners
dwgrshdfjkghjk
FGSHDTJF
taeysrudtfiyg
|
|
|
its ready |
DEATHB4DEFEAT
requested changes
Jan 18, 2024
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
|
I personally feel that the gun visuals do not match the current visual style of the game and this should not be merged until it does. |
|
There are also tests failing |
VMSolidus
reviewed
Apr 14, 2024
Comment on lines
+8
to
+15
| sprite: SimpleStation14\weapons\G11.rsi | ||
| layers: | ||
| - state: base | ||
| map: ["enum.GunVisualLayers.Base"] | ||
| - state: mag-0 | ||
| map: ["enum.GunVisualLayers.Mag"] | ||
| - type: Clothing | ||
| sprite: SimpleStation14\weapons\G11.rsi |
There was a problem hiding this comment.
Suggested change
| sprite: SimpleStation14\weapons\G11.rsi | |
| layers: | |
| - state: base | |
| map: ["enum.GunVisualLayers.Base"] | |
| - state: mag-0 | |
| map: ["enum.GunVisualLayers.Mag"] | |
| - type: Clothing | |
| sprite: SimpleStation14\weapons\G11.rsi | |
| sprite: SimpleStation14/weapons/G11.rsi | |
| layers: | |
| - state: base | |
| map: ["enum.GunVisualLayers.Base"] | |
| - state: mag-0 | |
| map: ["enum.GunVisualLayers.Mag"] | |
| - type: Clothing | |
| sprite: SimpleStation14/weapons/G11.rsi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kraut space magic
Tasks
Media
Changelog
🆑