[SL-UP] Removing the IP polling from the Matter code #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be done on CSA now. We are also not in a release cycle so it would be preferable to do it on CSA first. |
rosahay-silabs
requested changes
Feb 18, 2025
| @@ -724,14 +657,9 @@ void sl_matter_wifi_post_event(WifiEvent event) | |||
| /// and emits a WifiEvent::kStationDoDhcp event to trigger DHCP polling checks. Helper function for ProcessEvent. | |||
| void ResetDHCPNotificationFlags(void) | |||
There was a problem hiding this comment.
if DHCP related process is missing do we need this API? if yes, then it should be renamed.
| void NotifyConnectivity(void) | ||
| { | ||
| VerifyOrReturn(!hasNotifiedWifiConnectivity); | ||
| #if (CHIP_DEVICE_CONFIG_ENABLE_IPV4) |
There was a problem hiding this comment.
according to existing logic, we used to trigger these based on the relevant IPv4 and IPv6 events, this gives me the impression that no matter which among the two IPv4 IPv6 has been acquired we notify, is that understanding correct?
If yes, then do we need to keep track of the hasNotifiedWifiConnectivity event at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP polling and assignment is already a part of the wifi SDK code, so removing the code from the matter layer.
Keeping the notify code which is used for the notify the application about the connectivity
Testing
Multiple smoke runs were done to validate the change.
Tested on the 917 SoC