Web UI class cleanups #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairas
force-pushed
the
status_page_item
branch
from
a09b700 to
2bef409
Compare
They have no use for being FileSystemSaveable.
mairas
force-pushed
the
status_page_item
branch
2 times, most recently
from
da67018 to
8540630
Compare
mairas
force-pushed
the
status_page_item
branch
from
8540630 to
3ff2ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIOutputhas been renamed toStatusPageItem. It also inherits fromObservableValue.UILambdaOutputhas been removed. Instead, producers can be connected to the StatusPageItems to achieve dynamic updates.Also, System info sensors inherit directly from ValueProducer. Previously, they were Sensors, which made them FileSystemSaveable, which they really weren't.