fix: remove depricated message from ingestion dashboard #6862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove depricated message from ingestion dashboard
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6c6f7f3 in 18 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/app/dashboards/model.go:292
- Draft comment:
Ensure that removing the deprecated message does not affect any other logic or functionality that might rely on the description field. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes a deprecated message from the dashboard description. The change is straightforward and aligns with the PR description. However, the removal of the message should be verified to ensure it doesn't affect any other logic or functionality.
2. pkg/query-service/app/dashboards/model.go:292
- Draft comment:
The changes made in this PR do not violate any of the specified rules. The removal of the deprecated message is appropriate. - Reason this comment was not posted:
Confidence changes required:0%
The code does not violate any of the specified rules. The changes made in the PR are appropriate and do not introduce any new issues.
Workflow ID: wflow_98HxsbYy1QyN3FCt
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the custom message we added, the old users will already have ingestion v2.
For new users they can name it ingestion or anything
Important
Removes deprecated message from 'Ingestion' dashboard descriptions in
GetDashboard()inmodel.go.GetDashboard()inmodel.go.This description was created by
for 6c6f7f3. It will automatically update as commits are pushed.