-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update telemetry events #6804
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to e157ab8 in 2 minutes and 16 seconds
More details
- Looked at
664
lines of code in13
files - Skipped
0
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. pkg/query-service/rules/db.go:620
- Draft comment:
The update to incrementTotalActiveAlerts
only whenrule.PostableRule.Disabled
is false correctly aligns with the intent to count only active alerts. - Reason this comment was not posted:
Confidence changes required:10%
The change in theGetAlertsInfo
function inpkg/query-service/rules/db.go
correctly updates theTotalActiveAlerts
count by checking if the alert is not disabled. This aligns with the PR description's intent to update alerts count to only count active alerts.
2. pkg/query-service/app/server.go:530
- Draft comment:
The addition of detailed query information (e.g.,filterApplied
,groupByApplied
,aggregateOperator
, etc.) to the telemetry data aligns with the intent to provide more comprehensive query insights. - Reason this comment was not posted:
Confidence changes required:10%
The change inextractQueryRangeData
andextractQueryRangeV3Data
functions inpkg/query-service/app/server.go
ensures that the telemetry data includes additional query information such as filters, groupby, and aggregates. This aligns with the PR description's intent to update Query Range API to include more detailed information.
3. pkg/query-service/telemetry/telemetry.go:170
- Draft comment:
TheCheckQueryInfo
function now correctly extracts detailed query information, which is used for telemetry purposes. This aligns with the intent to provide more comprehensive query insights. - Reason this comment was not posted:
Confidence changes required:10%
The change inCheckQueryInfo
function inpkg/query-service/telemetry/telemetry.go
correctly extracts and returns detailed query information, which is then used in telemetry events. This aligns with the PR description's intent to update Query Range API to include more detailed information.
4. frontend/src/container/LogsExplorerList/index.tsx:72
- Draft comment:
The addition of a telemetry event for 'Logs Explorer: Data present' when data is available aligns with the intent to track data presence in explorers. - Reason this comment was not posted:
Confidence changes required:10%
The change infrontend/src/container/LogsExplorerList/index.tsx
adds a new telemetry event when data is present in the logs explorer. This aligns with the PR description's intent to add new events for data presence in explorers.
5. frontend/src/container/TracesExplorer/ListView/index.tsx:146
- Draft comment:
The addition of a telemetry event for 'Traces Explorer: Data present' when data is available aligns with the intent to track data presence in explorers. - Reason this comment was not posted:
Confidence changes required:10%
The change infrontend/src/container/TracesExplorer/ListView/index.tsx
adds a new telemetry event when data is present in the traces explorer. This aligns with the PR description's intent to add new events for data presence in explorers.
6. frontend/src/container/TimeSeriesView/TimeSeriesView.tsx:121
- Draft comment:
The addition of telemetry events for 'Traces Explorer: Data present' and 'Logs Explorer: Data present' when data is available aligns with the intent to track data presence in explorers. - Reason this comment was not posted:
Confidence changes required:10%
The change infrontend/src/container/TimeSeriesView/TimeSeriesView.tsx
adds a new telemetry event when data is present in the time series view. This aligns with the PR description's intent to add new events for data presence in explorers.
7. frontend/src/container/LogsExplorerList/index.tsx:1
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is also applicable to otherindex.tsx
files in the PR. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_JMewz0jrwocLsIcM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Logs Explorer: Data present
,Traces Explorer: Data present
Important
Update telemetry events to improve data accuracy, enhance Query Range API, and fix existing issues across multiple files.
db.go
andresponse.go
.Logs Explorer: Data present
andTraces Explorer: Data present
inindex.tsx
andTimeSeriesView.tsx
.Filter.tsx
.telemetry.go
.server.go
.CheckQueryInfo
to determine query details and update telemetry data inserver.go
andhttp_handler.go
.reader.go
andmodel.go
.model.go
.This description was created by for e157ab8. It will automatically update as commits are pushed.