Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time range from traces to logs #6634

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: time range from traces to logs #6634

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4693660
fix: timerange selected for traces to logs
vikrantgupta25 Dec 13, 2024
50fc83d
Merge branch 'develop' into wrong-timeline-for-traces-to-logs
vikrantgupta25 Dec 16, 2024
7334ac9
Merge branch 'develop' into wrong-timeline-for-traces-to-logs
vikrantgupta25 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions frontend/src/container/TraceDetail/SelectedSpanDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element {
history.push(
`${ROUTES.LOGS_EXPLORER}?${createQueryParams({
[QueryParams.compositeQuery]: JSON.stringify(query),
[QueryParams.startTime]: minTime,
[QueryParams.endTime]: maxTime,
// we subtract 1000 milliseconds from the start time to handle the cases when the trace duration is in nanoseconds
[QueryParams.startTime]: traceStartTime - 1000,
vikrantgupta25 marked this conversation as resolved.
Show resolved Hide resolved
// we add 1000 milliseconds to the end time for nano second duration traces
[QueryParams.endTime]: traceEndTime + 1000,
})}`,
);
};
Expand Down
Loading