-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some bugfixes and test refactoring #9
Open
jdesgats
wants to merge
14
commits into
SierraWireless:master
Choose a base branch
from
jdesgats:bugfix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current debugging logic was based on the assumption that coroutine.running() can return main thread, which is the case only when LuaJIT is compiled with LUAJIT_ENABLE_LUA52COMPAT. Now the debugger can be started on the top of user code, just like with regular 5.1 (with some modifications due to different tail call handling)
The new one has a custom Python bootstrapper and is based on LuaRocks (more simple and comprehensive than LuaDist). Python bootstrapper should be easy to port on Windows systems.
Conflicts: plugins/org.eclipse.koneki.ldt.debug.ui/src/org/eclipse/koneki/ldt/debug/ui/internal/launchconfiguration/local/LuaApplicationLaunchShortcut.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fixes compatibility with LuaJIT 2.0.0 and some global accesses.
Also, the test system has been refactored to use LuaRocks rather than LuaDist and has its own bootstrapper to build initial Lua VM (in Python, sorry)