Improved item name and type parsing #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlined namespaces, improved syntax, and adjusted parsing flow for better readability and maintainability. Updated header property assignments to ensure correct fallback logic and fixed minor issues in invariant item ID handling.
# Conflicts: # src/Sidekick.Apis.Poe/Parser/Headers/HeaderParser.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
Fixes #326
Pretty big refactor of Metadata and Header parsing to simplify maintenance moving forward.
Restored class parsing using regex for better parsing across languages. The fuzzy matching is still there as a fallback to catch new items sooner.