Fix problem where recycled group avatar icons have stale listener

Fixes signalapp#7089 // FREEBIE
SidaliNadji · Oct 13, 2017 · 4bd3094 · 4bd3094
1 parent 671023d
commit 4bd3094
Showing 1 changed file with 10 additions and 13 deletions.
diff --git a/src/org/thoughtcrime/securesms/components/AvatarImageView.java b/src/org/thoughtcrime/securesms/components/AvatarImageView.java
@@ -58,21 +58,18 @@ public void setAvatar(final @Nullable Recipient recipient, boolean quickContactE
 
   private void setAvatarClickHandler(final Recipient recipient, boolean quickContactEnabled) {
     if (!recipient.isGroupRecipient() && quickContactEnabled) {
-      setOnClickListener(new View.OnClickListener() {
-        @Override
-        public void onClick(View v) {
-          if (recipient.getContactUri() != null) {
-            ContactsContract.QuickContact.showQuickContact(getContext(), AvatarImageView.this, recipient.getContactUri(), ContactsContract.QuickContact.MODE_LARGE, null);
+      super.setOnClickListener(v -> {
+        if (recipient.getContactUri() != null) {
+          ContactsContract.QuickContact.showQuickContact(getContext(), AvatarImageView.this, recipient.getContactUri(), ContactsContract.QuickContact.MODE_LARGE, null);
+        } else {
+          final Intent intent = new Intent(Intent.ACTION_INSERT_OR_EDIT);
+          if (recipient.getAddress().isEmail()) {
+            intent.putExtra(ContactsContract.Intents.Insert.EMAIL, recipient.getAddress().toEmailString());
           } else {
-            final Intent intent = new Intent(Intent.ACTION_INSERT_OR_EDIT);
-            if (recipient.getAddress().isEmail()) {
-              intent.putExtra(ContactsContract.Intents.Insert.EMAIL, recipient.getAddress().toEmailString());
-            } else {
-              intent.putExtra(ContactsContract.Intents.Insert.PHONE, recipient.getAddress().toPhoneString());
-            }
-            intent.setType(ContactsContract.Contacts.CONTENT_ITEM_TYPE);
-            getContext().startActivity(intent);
+            intent.putExtra(ContactsContract.Intents.Insert.PHONE, recipient.getAddress().toPhoneString());
           }
+          intent.setType(ContactsContract.Contacts.CONTENT_ITEM_TYPE);
+          getContext().startActivity(intent);
         }
       });
     } else {