Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding layouts with DRC issues #209

Merged
merged 1 commit into from
May 19, 2024
Merged

adding layouts with DRC issues #209

merged 1 commit into from
May 19, 2024

Conversation

newmansc2
Copy link
Contributor

These layouts have DRC issues that I wasn't able to resolve. Committing anyway in case they can be accepted.

I realize it is past the deadline and these layouts therefore are unlikely to be accepted in any case.

These files have DRC issues that I wasn't able to resolve.  Committing anyway in case they can be accepted.
@lukasc-ubc
Copy link
Member

For the disks: it would be better to create a PCell. @newmansc2 would you like to write such a PCell and contribute it the PDK?

For the CDCs, indeed, the ports are so close together that it makes it impossible to connect waveguides. We need some sort of IO cell, @mustafacc? Perhaps a separate PCell for IO? Or an option on the CDC to add the ports. I guess we already have the EBeam.contra_directional_coupler cell which does the same thing as EBeam_Beta.Contra_DC cell, so should we remove the Beta one?

@lukasc-ubc lukasc-ubc merged commit ac7493d into SiEPIC:main May 19, 2024
1 of 2 checks passed
@newmansc2
Copy link
Contributor Author

@lukasc-ubc thanks for the feedback. I would like to contribute by making a disk resonator PCell. I don't currently know how to do this, but this would be a good learning opportunity. I'll put it on my to-do list.

@lukasc-ubc
Copy link
Member

My suggestion is:

  • look at the wg_heater or ebeam_dc_halfring_straight PCell in the EBeam library to see how to create a PCell.
  • KLayout has a native PCell for a disk (see screenshot)
  • look at ring_doublebus in the EBeam_PDK library to see how to instantiate a PCell inside a PCell

Feel free to start a PR and I can give you feedback.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants