Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to properly run EBeam_Lib_PCellTests.py (in action EBeam Tests) when a new pcell is added #271

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

jasminabrar
Copy link
Contributor

Context: previously if a new pcell was added in a PR or direct push, the script would give a pcell Registration error because it was using a docker container with siepic ebeam pdk that was cloned without the newly added pcell

Solution

  • when someone pushes or opens a PR with a newly added pcell, it is copied into siepic ebeam pdk in the docker container so that the tests can be properly performed
  • after the PR is merged (or right away if it is a direct push) a new docker image is built with the latest siepic ebeam pdk, which will include the added pcell(s)

…sting

Then trigger docker build to rebuild the image with the added pcells in the direct push or after the merged PR
@lukasc-ubc lukasc-ubc merged commit 88584b5 into SiEPIC:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants