argBodyにundefinedを含む場合はinvalidにする。テストコードの追加 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2022 15:16
mii288
reviewed
May 10, 2022
| throw new Error( | ||
| "引数が正しく渡されていません。もう一度helpを見てください。" | ||
| ); | ||
| } | ||
|
|
||
| const args = body.text?.split(" "); |
There was a problem hiding this comment.
https://github.com/ShuzoN/zut/blob/master/src/Types/lambda.ts#L2
stringってnull許容でしたっけ？(覚えてない)
There was a problem hiding this comment.
このtypesが正しければ大丈夫です！
emptyの場合はundefinedではなくnullをセットするライブラリが多いので、lambdaはどうなのかなと思ったところでした。
There was a problem hiding this comment.
あーたしかに。types/aws-lambdaみときます
added 2 commits
May 10, 2022 15:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #84
テストコード足したいのとsplitする前にそもそもundefinedだったら落とすようにする。