[feature] - search multitenant workflow run search in parent org #145
Conversation
| } | ||
|
|
||
| // Limit to max 50 suborgs | ||
| if len(suborgs) > 50 { |
There was a problem hiding this comment.
Minor unimportant optimization: Shouldn't the check for the user existing in an org happen earlier? Inside the goroutine is "efficient", but it can randomly turn into search e.g. 27 orgs instead of 50, as the cleanup happens before we check if they should be able to see it.
There was a problem hiding this comment.
true, I will update that check.
There was a problem hiding this comment.
Update code in this commit: 42ce125
| @@ -28483,6 +28483,104 @@ func HandleWorkflowRunSearch(resp http.ResponseWriter, request *http.Request) { | |||
| Cursor: cursor, | |||
| } | |||
|
|
|||
| //Get workflow run for all subgs of current org where the user is a member | |||
| if search.SuborgRuns == true { | |||
There was a problem hiding this comment.
What happens if the search is specifically for a single workflow? Do we just remove the filter?
I'm aware we said we would wait with this, but the if statement needs to at least take it into account as to not "randomly" add a bunch of suborg workflows.
There was a problem hiding this comment.
Yes, when suborg workflow run search is one and if user select any specific workflow to search than it clear filter for suborg and then only search for that workflow
No description provided.