Use rubocop-shopify gem (#920)

.gitignore

@@ -1,4 +1,3 @@
-.rubocop-*
 .tmp/*
 .bundle/*
 .DS_Store

.rubocop.yml

@@ -1,5 +1,8 @@
-inherit_from:
-  - https://shopify.github.io/ruby-style-guide/rubocop-cli.yml
+inherit_from: .rubocop_todo.yml
+
+inherit_gem:
+  rubocop-shopify:
+    - rubocop-cli.yml
 
 AllCops:
   Exclude:

.rubocop_todo.yml

@@ -0,0 +1,20 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-10-17 00:53:36 UTC using RuboCop version 0.93.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 66
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreMacros, IgnoredMethods, IgnoredPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
+# SupportedStyles: require_parentheses, omit_parentheses
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'test/test_helper.rb'

Gemfile

@@ -8,7 +8,7 @@ group :development, :test do
   gem 'rake'
   gem 'pry-byebug'
   gem 'byebug'
-  gem 'rubocop'
+  gem 'rubocop-shopify', require: false
 end
 
 group :test do

Gemfile.lock

@@ -23,7 +23,7 @@ GEM
     mocha (1.7.0)
       metaclass (~> 0.0.1)
     parallel (1.19.2)
-    parser (2.7.1.4)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
@@ -34,19 +34,21 @@ GEM
     public_suffix (3.0.3)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
-    rubocop (0.89.1)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.1.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.3.0, < 1.0)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.3.0)
-      parser (>= 2.7.1.4)
+    rubocop-ast (0.8.0)
+      parser (>= 2.7.1.5)
+    rubocop-shopify (1.0.6)
+      rubocop (>= 0.92, < 0.94)
     ruby-progressbar (1.10.1)
     safe_yaml (1.0.4)
     timecop (0.9.1)
@@ -67,7 +69,7 @@ DEPENDENCIES
   mocha
   pry-byebug
   rake
-  rubocop
+  rubocop-shopify
   timecop
   webmock