Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Commit

Permalink
Update release instructions (#962)
Browse files Browse the repository at this point in the history
* Fixed steps regarding workflow

* Remove unncessary comment

* Clarify steps'
  • Loading branch information
mllemango authored Nov 5, 2020
1 parent d23176f commit 1e6f557
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
tap: shopify/shopify
formula: shopify-cli
tag: ${{ steps.folder.outputs.name }}
message: "Version bump, created by github actions"

- name: Create Release # https://hub.github.com/hub-release.1.html
env:
Expand Down
18 changes: 5 additions & 13 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,11 @@

1. Deploy using Shipit

1. Update your `master` branch to the latest version
```
$ git checkout master
$ git pull
```
1. Check the "Actions" tab to see if the _Create Release_ workflow is successful.
The workflow will automatically create a [release](https://github.com/Shopify/shopify-app-cli/releases) with the latest tag and `.deb`, `.rpm` assets attached.

1. On local machine and _AFTER_ gem has been published to https://rubygems.org, run
```
$ rake package
```
This will generate the `.deb`, `.rpm` and brew formula files, which will be located in `packaging/builds/X.Y.Z/`.
2. Check the `Shopify/homebrew-shopify` repository for new PR `shopify-cli {version}`
* rename PR to `Packaging for release of v{version} of shopify-cli`
* when PR is approved, merge into main branch

1. Check the "Actions" tab to see if the _Create Release_ workflow is successful.
The workflow will automatically create a release with the latest tag and the `.deb`, `.rpm` assets attached.

1. Check the `Shopify/homebrew-shopify` repository for new branch `bump-shopify-cli-{version}` and create PR.

0 comments on commit 1e6f557

Please sign in to comment.