Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds utility methods to find current shop, current recurring application charge #951

Closed
wants to merge 2 commits into from
Closed

Adds utility methods to find current shop, current recurring application charge #951

wants to merge 2 commits into from

Conversation

mkevinosullivan
Copy link
Contributor

@mkevinosullivan mkevinosullivan commented May 9, 2022 •
edited
Loading

Description

Adds utility methods to find current shop and current recurring application charge, functionality that had been available in v9 of API when it used ActiveResource.

Fixes #923

How has this been tested?

Unit tests added for each new method current_shop, current_recurring_application_charge
Please, describe the tests that you ran to verify your changes.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@mkevinosullivan mkevinosullivan force-pushed the kos/fix_923_add_current_methods_to_utils branch 3 times, most recently from 9e47058 to b5777c2 Compare May 9, 2022 18:18
@mkevinosullivan mkevinosullivan marked this pull request as ready for review May 16, 2022 16:06
@mkevinosullivan mkevinosullivan requested a review from a team as a code owner May 16, 2022 16:06
@mkevinosullivan mkevinosullivan force-pushed the kos/fix_923_add_current_methods_to_utils branch from b5777c2 to 6b4ffdc Compare May 16, 2022 16:08
@mkevinosullivan mkevinosullivan changed the title [WIP] Adds utility methods to find current shop, current recurring application charge Adds utility methods to find current shop, current recurring application charge May 16, 2022
paulomarg
paulomarg reviewed May 16, 2022
View reviewed changes
test/utils_test.rb Outdated Show resolved Hide resolved
lib/shopify_api/utils.rb Outdated Show resolved Hide resolved
test/utils_test.rb Outdated Show resolved Hide resolved
test/utils_test.rb
end

sig { void }
def test_current_recurring_application_charge_no_active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this test, we should probably have a similar one for the shop method!

test/utils_test.rb Outdated Show resolved Hide resolved
@paulomarg paulomarg force-pushed the kos/fix_923_add_current_methods_to_utils branch from e6b6efc to f84c474 Compare July 19, 2022 17:57
@schonert
Copy link

Any news on this? 👀

@mkevinosullivan mkevinosullivan force-pushed the kos/fix_923_add_current_methods_to_utils branch 3 times, most recently from a1d9789 to 4c1e9c2 Compare September 16, 2022 19:19
@mkevinosullivan
Adds current shop, recurring application charges
1c5a39e 
Adds utility methods to find current shop and current recurring
application charges, functionality that had been available in v9 of API
when it used ActiveResource.

Fixes 923
@mkevinosullivan mkevinosullivan force-pushed the kos/fix_923_add_current_methods_to_utils branch from 4c1e9c2 to 1c5a39e Compare September 16, 2022 19:22
@github-actions
Copy link

This pull request is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Mar 22, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

We are closing this pull request because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this pull request with the latest stable version, please reopen using the pull request template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this Apr 6, 2023
@kirillplatonov
Copy link
Contributor

@lizkenyon @paulomarg is it possible to reopen and finish this one? The original issue (#923) is still relevant and we have to monkey patch ShopifyAPI::Shop and ShopifyAPI::RecurringApplicationCharge in every project to bring those methods back.

P.S. v10 upgrade guide have no notices that these methods have been removed: https://github.com/Shopify/shopify-api-ruby/blob/main/BREAKING_CHANGES_FOR_V10.md
It might make sense to add them as every dev who upgrades old apps will struggle with it.

@paulomarg
Copy link
Contributor

Hey, thanks for raising this, I think you have a point in that this was an unannounced removal. I'll reopen and add this back to our tracking so we can finalize it.

@paulomarg paulomarg reopened this Aug 12, 2024
@paulomarg
Copy link
Contributor

I ended up creating a new PR since this one was quite outdated and it'd be more work to get it to work than starting over. Closing in favor of #1335

@paulomarg paulomarg closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .current method back to ShopifyAPI::Shop and ShopifyAPI::RecurringApplicationCharge
4 participants
@mkevinosullivan @schonert @kirillplatonov @paulomarg