Fixes DiscountCode errors type, adds new BatchResult type #1276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #1205
What is the problem it is solving?
DiscountCode has duplicated
errors
field which is only returned on batch operation results.What is the context of these changes?
Adds new return type using
BatchResult
struct and new method to return the right type for batch result request in https://shopify.dev/docs/api/admin-rest/2024-01/resources/discountcode#get-price-rules-price-rule-id-batch-batch-id-discount-codesWhat is the impact of this PR?
This adds a new method and deprecate an existing method. It should not impact existing users, and migration is optional.
How has this been tested?
Setup a new ruby project with the following script
Run it with
This script prints the following result
Checklist: