Fixed bug that doesn't allow for uppercase letters in redirect_uri #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaykayrey could you please sign the CLA? |
|
I have signed the CLA! |
|
@jaykayrey Can you please add a entry to the CHANGELOG.md. Then I will merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug that didn't allow for redirectPath (redirect_uri in Shopify's API) in the Shopify\Auth\OAuth::begin.
Currently, if you submit a redirectPath with uppercase letters it will make them all lowercase.
Example: "/My/Redirect/Path.php" will become "/my/redirect/path.php" which will make it no longer match the allowed redirect URIs set in the Shopify Partners interface, and also not match the actual redirect.
This only removes the strtolower() being called on the $redirectPath.