Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve code quality with rector rules #328

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

shakaran
Copy link
Contributor

@shakaran shakaran commented Mar 2, 2024

Improve code quality over src and tests folders appling rector rules with PHP 8.1 support.

Applied rules:

Type of change

  • Minor: New feature (non-breaking change which adds functionality)

Checklist

  • I have added/updated tests for this change

@shakaran
Copy link
Contributor Author

shakaran commented Mar 2, 2024

Hi @paulomarg, just let me know if you need more info about the changes. This is a batch of updates and improvements (first iteration). I have pending more to send when this gets merged. Thanks!

@paulomarg
Copy link
Contributor

I think these changes are ok, but if we're going to add something like this, we should also include the scripts / rules so that others can also run it.

@shakaran
Copy link
Contributor Author

I think these changes are ok, but if we're going to add something like this, we should also include the scripts / rules so that others can also run it.

ok, no prob, after you merge this, I will send more PR and one with the rector config rule. Also I can add in a CI for the future PR

@matteodepalo matteodepalo merged commit d3690a6 into Shopify:main Apr 18, 2024
4 checks passed
@shakaran shakaran deleted the feat/improve-code-quality-rector branch April 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants