Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

graphql-config 4 update #2057

Closed
wants to merge 1 commit into from
Closed

graphql-config 4 update #2057

wants to merge 1 commit into from

Conversation

dahukish
Copy link
Contributor

@dahukish dahukish commented Oct 18, 2021

Description

Breaking Changes

This PR:

  • Updates graphql-config-utilities, graphql-typescript-definitions, graphql-validate-fixtures to graphql-config v4.
  • Updates eslint-plugin (blocked)
  • Updates the version of node to "node": "^12.22.0 || ^14.17.0 || >=16.0.0" (graphql-config v4 requires a minimum or NodeJS 12.20)
  • updates @shopify/browserlist-config to 3.0.0
  • updates browserslist-useragent to 3.0.3

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • all packages Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@dahukish dahukish self-assigned this Oct 18, 2021
@dahukish dahukish requested a review from vsumner October 18, 2021 22:06
@BPScott
Copy link
Member

BPScott commented Oct 19, 2021

Updating the engines field is a breaking change, so currently this will require a major bump to everything. That seems at odds with whats in the PR description. If the goal is to only support node versions with stable ESM support, then you'll need to use ^12.22.0 || ^14.17.0 || >=16.0.0.

If we need to version bump the node engines of everything, then can we also update the node and browser compile targets at the same time per #1970, so that we reduce the number of major versions we release

@dahukish
Copy link
Contributor Author

dahukish commented Oct 19, 2021

Updating the engines field is a breaking change, so currently this will require a major bump to everything. That seems at odds with whats in the PR description. If the goal is to only support node versions with stable ESM support, then you'll need to use ^12.22.0 || ^14.17.0 || >=16.0.0.

If we need to version bump the node engines of everything, then can we also update the node and browser compile targets at the same time per #1970, so that we reduce the number of major versions we release

@BPScott

graphql-config v4 only supports => 12.20 so I figured I would make the minimum version be 12.22. Also all the versions need to be the same as I can't bump only the three packages (so I could have said all the packages are breaking). Also web is stuck at 14.16.1 for now.

@dahukish
Copy link
Contributor Author

Currently waiting on either this: apollographql/eslint-plugin-graphql#311
or this: apollographql/eslint-plugin-graphql#317 to be merged and published. As this PR is blocked by https://github.com/Shopify/web-configs/tree/main/packages/eslint-plugin need any of the above to 🚢

@dahukish dahukish force-pushed the update-graphql-config branch 2 times, most recently from 7f71c98 to 23a22fa Compare October 19, 2021 16:57
@dahukish dahukish force-pushed the update-graphql-config branch from 23a22fa to 66a38e8 Compare October 19, 2021 17:54
@BPScott
Copy link
Member

BPScott commented Oct 19, 2021

graphql-config v4 only supports => 12.20 so I figured I would make the minimum version be 12.22.

Figured that was gonna be the case :) I love the plan to update everything to "^12.22.0 || ^14.17.0 || >=16.0.0", but I think that version bump across the board should be a separate PR to the graphql-config update otherwise it'll get lost in the noise

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants