Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

WIP: Remove shopify provider dependency #122

Open
wants to merge 4 commits into
base: 2023-01
Choose a base branch
from

Conversation

juanpprieto
Copy link
Contributor

@juanpprieto juanpprieto commented Jan 17, 2023

Description

  • Remove ShopifyProvider dependency from components using useShop by adding optional props.
  • Adds a remix app to showcase components without ShopifyProvider

Closes https://github.com/Shopify/storefront-kit/issues/86

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes Shopify/hydrogen-react#123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog. If you have a breaking change, it will need to wait until the next major version release. Otherwise, use patch updates even for new features. Read more about Storefront Kit's versioning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant