-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs on searching #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic :) left a couple of comments
I've updated the text like so to reflect the feedback: 0430583 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, have added another comment. One more thing though - just to confuse you some more 😅 - the docs are built from the master branch so if you can rebase to master that would be awesome. Else I can always squash commit this and cherry pick it.
I think it would be best to squash the commits and cherry pick it then both branches will have the up to date documentation and it won't confuse anyone else why there's two different versions of the documentation😄. (And I won't confuse myself 😅 ). Anyways wouldn't it be easier to build the documentation from the current default branch and just have the default branch be the newest version of Examine? I can see that you already use
I also see that you have some vX.X branches and maybe those are meant to be for that? For example:
Another way I've been having great success with is using the same scheme as Umbraco:
Then it's clear to see which branch is the newest version of what major release and you just have to make a new branch and make it default when a new major is needed. And if a developer needs to look at a specific version like Essentially I'm saying that the current |
Adds to #190
Updated code examples and added some more information by looking trough the code and referencing this page: https://lucene.apache.org/core/4_8_0/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#package_description
This also adds more information to the XML on
.Fuzzy()
.