Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arb_translate package to auto-translate the app strings #1801

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Jan 10, 2025

With the arb_translate package we can auto-translate our app strings. The package uses Gemini for translation. Using a Large Language Model (LLM) has the advantage that we can provide additional context to our application and the strings.

The package will translate the untranslated strings. You can always overwrite the automatic translation with your own translation.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
lib/sharezone_localizations/README.md (1)

27-27: Consider enhancing the feature description.

The feature entry is well-formatted, but could benefit from mentioning the key advantages, such as the context-aware translations using Gemini LLM.

-- Auto-translate with [arb_translate](https://pub.dev/packages/arb_translate): Use the arb_translate package to auto-translate your .arb files.
++ Auto-translate with [arb_translate](https://pub.dev/packages/arb_translate): Automatically translate .arb files using Gemini LLM, providing context-aware translations for better accuracy.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a03a8a and 0049712.

⛔ Files ignored due to path filters (1)
  • lib/sharezone_localizations/l10n.yaml is excluded by !**/*.yaml
📒 Files selected for processing (1)
  • lib/sharezone_localizations/README.md (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: web-preview
  • GitHub Check: web-preview
  • GitHub Check: web-preview
  • GitHub Check: analyze
  • GitHub Check: test-without-goldens
  • GitHub Check: test-with-goldens
  • GitHub Check: analyze
  • GitHub Check: analyze
  • GitHub Check: check-dependency-licenses
🔇 Additional comments (1)
lib/sharezone_localizations/README.md (1)

16-16: LGTM! Well-structured TOC update.

The new section is properly added to the table of contents with correct formatting and linking.

lib/sharezone_localizations/README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 10, 2025

Visit the preview URL for this PR (updated for commit d7822c8):

https://sharezone-test--pr1801-add-auto-translate-10j4xqpy.web.app

(expires Mon, 13 Jan 2025 09:53:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@SharezoneApp SharezoneApp deleted a comment from coderabbitai bot Jan 10, 2025
@SharezoneApp SharezoneApp deleted a comment from github-actions bot Jan 10, 2025
@SharezoneApp SharezoneApp deleted a comment from github-actions bot Jan 10, 2025
@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 500f190 Jan 10, 2025
38 checks passed
@nilsreichardt nilsreichardt deleted the add-auto-translate branch January 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants