Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages with flutter/dart pub upgrade #1742

Merged
merged 22 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions .github/workflows/integration_tests_app_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
channel: ${{ steps.fvm-config-action.outputs.FLUTTER_CHANNEL }}

- name: Install patrol cli
run: flutter pub global activate patrol_cli 2.5.0
run: flutter pub global activate patrol_cli 3.2.0

- name: Run Flutter build
run: |
Expand Down Expand Up @@ -169,12 +169,7 @@ jobs:

ios-integration-test:
needs: changes
# We are using macos-12 instead macos-13 because with macos-13 we have job
# times of 40 - 120 minutes.
#
# Before switching back to macos-13, we should check if the job times are
# still that long by running the job with a matrix (3 runs).
runs-on: macos-12
runs-on: macos-15
if: ${{ needs.changes.outputs.changesFound == 'true' }}
timeout-minutes: 60
steps:
Expand All @@ -189,16 +184,18 @@ jobs:
flutter-version: ${{ steps.fvm-config-action.outputs.FLUTTER_VERSION }}
channel: ${{ steps.fvm-config-action.outputs.FLUTTER_CHANNEL }}

# Because macos-12 doesn't have Metal support, we need to disable Impeller
# https://github.com/flutter/flutter/issues/126768
- name: Disable Impeller
working-directory: app/ios/Runner
run: /usr/libexec/PlistBuddy -c "Add :FLTEnableImpeller bool false" Info.plist

- uses: futureware-tech/simulator-action@48e51da14445b3eedca643bba4b78d9d8332ff31
id: simulator
with:
model: "iPhone 13"
model: "iPhone 16"

- name: Build app
working-directory: app
run: |
flutter build ipa \
--flavor dev \
-t lib/main_dev.dart \
--no-codesign

- name: Run integration tests
working-directory: app
Expand All @@ -216,9 +213,7 @@ jobs:
# using not the default flavor will cause an exception when
# uninstalling the app, see:
# https://github.com/flutter/flutter/issues/88690
flutter drive \
--driver=test_driver/integration_test.dart \
--target=integration_test/integration_test_old.dart \
flutter test integration_test/integration_test_old.dart \
--flavor prod \
--dart-define=USER_1_EMAIL=$USER_1_EMAIL \
--dart-define=USER_1_PASSWORD=$USER_1_PASSWORD \
Expand Down
2 changes: 1 addition & 1 deletion app/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelpe
flutter_ios_podfile_setup

target 'Runner' do
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '10.24.0'
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '10.25.0'

use_frameworks!
use_modular_headers!
Expand Down
Loading
Loading